From: Al Viro <viro@ZenIV.linux.org.uk>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: linux-kernel@vger.kernel.org, jens.axboe@oracle.com
Subject: Re: [PATCH 2/2] loop : Don't hold the lo_ctl_mutex while fput in loop_clr_fd
Date: Mon, 28 Apr 2008 03:15:31 +0100 [thread overview]
Message-ID: <20080428021531.GA5882@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20080428021309.GZ5882@ZenIV.linux.org.uk>
On Mon, Apr 28, 2008 at 03:13:09AM +0100, Al Viro wrote:
> On Mon, Apr 28, 2008 at 10:10:22AM +0800, Dave Young wrote:
> > [Fixing bug 10504]
> >
> > If the bakingfile is a block device file, losetuo -d will trigger lockdep
> > warning of "circular locking dependency".
> >
> > open/release lock order : bdev->bd_mutex ---> lo->lo_ctl_mutex
> > loop_clr_fd lock order : lo->lo_ctl_mutex ---> bdev->bd_mutex (fput)
> >
> > Don't hold the lo_ctl_mutex while fput in loop_clr_fd to fix it. It's safe
> > because all loop device state will be consistent here.
>
> Explain.
BTW, explain also why open() at that spot will not do interesting things
wrt BLKRRPART done a bit below, please.
next prev parent reply other threads:[~2008-04-28 2:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 2:10 [PATCH 2/2] loop : Don't hold the lo_ctl_mutex while fput in loop_clr_fd Dave Young
2008-04-28 2:13 ` Al Viro
2008-04-28 2:15 ` Al Viro [this message]
2008-04-28 2:33 ` Dave Young
2009-03-01 9:47 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080428021531.GA5882@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hidave.darkstar@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox