From: Paul Jackson <pj@sgi.com>
To: WANG Cong <xiyou.wangcong@gmail.com>
Cc: bert.wesarg@googlemail.com, mingo@elte.hu,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org, travis@sgi.com
Subject: Re: [PATCH] Fix calculus of bitmap_scnprintf_len()
Date: Mon, 28 Apr 2008 08:13:26 -0500 [thread overview]
Message-ID: <20080428081326.fc62f1ce.pj@sgi.com> (raw)
In-Reply-To: <alpine.LFD.1.00.0804281414020.2870@localhost.localdomain>
Bert wrote:
> The function bitmap_scnprintf_len() is currently not used
Paul Jackson wrote:
> How about we just remove that function?
WANG Cong wrote:
> I am afraid no. See:
>
> include/linux/cpumask.h:292: return bitmap_scnprintf_len(len);
Good point.
Then how about we also remove from cpumask.h:
#define cpumask_scnprintf_len(len) \
__cpumask_scnprintf_len((len))
static inline int __cpumask_scnprintf_len(int len)
{
return bitmap_scnprintf_len(len);
}
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.940.382.4214
next prev parent reply other threads:[~2008-04-28 13:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-27 20:43 [PATCH] Fix calculus of bitmap_scnprintf_len() Bert Wesarg
2008-04-27 21:01 ` Paul Jackson
2008-04-28 6:14 ` WANG Cong
2008-04-28 13:13 ` Paul Jackson [this message]
2008-04-28 17:09 ` Mike Travis
2008-04-28 17:31 ` Bert Wesarg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080428081326.fc62f1ce.pj@sgi.com \
--to=pj@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=bert.wesarg@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
--cc=travis@sgi.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox