public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andres Salomon <dilinger@queued.net>
To: Andres Salomon <dilinger@queued.net>
Cc: sam@ravnborg.org, Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com
Subject: Re: [PATCH 1/4] build: fix missing x86-specific help output
Date: Mon, 28 Apr 2008 11:18:39 -0400	[thread overview]
Message-ID: <20080428111839.5f8d5669@ephemeral> (raw)
In-Reply-To: <20080425223458.4eb88ba6@ephemeral>

Note that this one is a general x86 fix, I probably should've separated it
out from the other three.

On Fri, 25 Apr 2008 22:34:58 -0400
Andres Salomon <dilinger@queued.net> wrote:

> 
> Normally 'make help' spits out architecture-specific targets (including
> things like foo_defconfig).  However, it looks like ARCH was never changed
> to SRCARCH during the x86 transition; the makefile still looks in
> arch/i386/configs for arch-specific config files (if ARCH is i386, that is).
> 
> This changes it to use SRCARCH, which makes it properly display things
> like i386_defconfig and x86_64_defconfig.
> 
> Signed-off-by: Andres Salomon <dilinger@debian.org>
> ---
>  Makefile |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 3dbc826..e77149e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1170,7 +1170,7 @@ rpm: include/config/kernel.release FORCE
>  # Brief documentation of the typical targets used
>  # ---------------------------------------------------------------------------
>  
> -boards := $(wildcard $(srctree)/arch/$(ARCH)/configs/*_defconfig)
> +boards := $(wildcard $(srctree)/arch/$(SRCARCH)/configs/*_defconfig)
>  boards := $(notdir $(boards))
>  
>  help:
> @@ -1217,9 +1217,9 @@ help:
>  	@echo  'Documentation targets:'
>  	@$(MAKE) -f $(srctree)/Documentation/DocBook/Makefile dochelp
>  	@echo  ''
> -	@echo  'Architecture specific targets ($(ARCH)):'
> +	@echo  'Architecture specific targets ($(SRCARCH)):'
>  	@$(if $(archhelp),$(archhelp),\
> -		echo '  No architecture specific help defined for $(ARCH)')
> +		echo '  No architecture specific help defined for $(SRCARCH)')
>  	@echo  ''
>  	@$(if $(boards), \
>  		$(foreach b, $(boards), \

  reply	other threads:[~2008-04-28 15:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-26  2:34 [PATCH 1/4] build: fix missing x86-specific help output Andres Salomon
2008-04-28 15:18 ` Andres Salomon [this message]
2008-04-28 20:46   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080428111839.5f8d5669@ephemeral \
    --to=dilinger@queued.net \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=sam@ravnborg.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox