From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932383AbYD1MAy (ORCPT ); Mon, 28 Apr 2008 08:00:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1765067AbYD1MAo (ORCPT ); Mon, 28 Apr 2008 08:00:44 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:37256 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763526AbYD1MAn (ORCPT ); Mon, 28 Apr 2008 08:00:43 -0400 Date: Mon, 28 Apr 2008 14:00:32 +0200 From: Ingo Molnar To: Mauro Carvalho Chehab Cc: linux-kernel@vger.kernel.org Subject: [patch] video: fix SOC_CAMERA_MT9M001 build bug Message-ID: <20080428120032.GA23847@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org on latest -git, with this config: http://redhat.com/~mingo/misc/config-Mon_Apr_28_13_25_34_CEST_2008.bad CONFIG_SOC_CAMERA_MT9M001=y CONFIG_SOC_CAMERA_MT9V022=y # CONFIG_I2C is not set the build fails: drivers/built-in.o: In function `reg_read': mt9m001.c:(.text+0x140a87): undefined reference to `i2c_smbus_read_word_data' drivers/built-in.o: In function `reg_write': mt9m001.c:(.text+0x140b6e): undefined reference to `i2c_smbus_write_word_data' drivers/built-in.o: In function `reg_read': mt9v022.c:(.text+0x1413a7): undefined reference to `i2c_smbus_read_word_data' drivers/built-in.o: In function `reg_write': mt9v022.c:(.text+0x1414ce): undefined reference to `i2c_smbus_write_word_data' drivers/built-in.o: In function `mt9m001_mod_init': mt9m001.c:(.init.text+0x158a8): undefined reference to `i2c_register_driver' drivers/built-in.o: In function `mt9v022_mod_init': mt9v022.c:(.init.text+0x158b8): undefined reference to `i2c_register_driver' drivers/built-in.o: In function `mt9m001_mod_exit': mt9m001.c:(.exit.text+0x1656): undefined reference to `i2c_del_driver' drivers/built-in.o: In function `mt9v022_mod_exit': mt9v022.c:(.exit.text+0x1666): undefined reference to `i2c_del_driver' adding the missing I2C dependency fixes it. Signed-off-by: Ingo Molnar --- drivers/media/video/Kconfig | 1 + 1 file changed, 1 insertion(+) Index: linux/drivers/media/video/Kconfig =================================================================== --- linux.orig/drivers/media/video/Kconfig +++ linux/drivers/media/video/Kconfig @@ -850,6 +850,7 @@ endif # V4L_USB_DRIVERS config SOC_CAMERA tristate "SoC camera support" depends on VIDEO_V4L2 + depends on I2C select VIDEOBUF_DMA_SG help SoC Camera is a common API to several cameras, not connecting