public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Roland McGrath <roland@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86_64 vDSO: use initdata
Date: Mon, 28 Apr 2008 15:14:08 +0200	[thread overview]
Message-ID: <20080428131408.GI27997@elte.hu> (raw)
In-Reply-To: <20080428014538.DC68926F8F0@magilla.localdomain>


* Roland McGrath <roland@redhat.com> wrote:

> The 64-bit vDSO image is in a special ".vdso" section for no reason I 
> can determine.  Furthermore, the location of the vdso_end symbol 
> includes some wrongly-calculated padding space in the image, which is 
> then (correctly) rounded to page size, resulting in an extra page of 
> zeros in the image mapped in to user processes.
> 
> This changes it to put the vdso.so image into normal initdata as we 
> have always done for the 32-bit vDSO images.  The extra padding is 
> gone, so the user VMA is one page instead of two.  The image that was 
> already copied around at boot time is now in initdata, so we recover 
> that wasted space after boot.

thanks Roland, applied. I suspect this will need a few days of test-time 
as we change the user-space vma layout. (not in material ways though)

	Ingo

      reply	other threads:[~2008-04-28 13:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-28  1:45 [PATCH] x86_64 vDSO: use initdata Roland McGrath
2008-04-28 13:14 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080428131408.GI27997@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox