From: Jan Blunck <jblunck@suse.de>
To: Linux-Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux-fsdevel Mailinglist <linux-fsdevel@vger.kernel.org>
Cc: Trond.Myklebust@netapp.com, linux-nfs@vger.kernel.org
Subject: [PATCH 2/3] NFS: path_{get,put}() cleanups
Date: Mon, 28 Apr 2008 18:37:33 +0200 [thread overview]
Message-ID: <20080428163732.072893435@T61.localnet> (raw)
In-Reply-To: 20080428163731.774191296@T61.localnet
[-- Attachment #1: vfs/path_get_put-cleanups-nfs.diff --]
[-- Type: text/plain, Size: 1756 bytes --]
Here are some more places where path_{get,put}() can be used instead of
dput()/mntput() pair.
Signed-off-by: Jan Blunck <jblunck@suse.de>
---
fs/nfs/inode.c | 3 +--
fs/nfs/namespace.c | 3 +--
fs/nfs/nfs4proc.c | 6 ++----
3 files changed, 4 insertions(+), 8 deletions(-)
Index: b/fs/nfs/inode.c
===================================================================
--- a/fs/nfs/inode.c
+++ b/fs/nfs/inode.c
@@ -541,8 +541,7 @@ static void __put_nfs_open_context(struc
}
if (ctx->cred != NULL)
put_rpccred(ctx->cred);
- dput(ctx->path.dentry);
- mntput(ctx->path.mnt);
+ path_put(&ctx->path);
kfree(ctx);
}
Index: b/fs/nfs/namespace.c
===================================================================
--- a/fs/nfs/namespace.c
+++ b/fs/nfs/namespace.c
@@ -137,8 +137,7 @@ static void * nfs_follow_mountpoint(stru
goto out_follow;
goto out_err;
}
- mntput(nd->path.mnt);
- dput(nd->path.dentry);
+ path_put(&nd->path);
nd->path.mnt = mnt;
nd->path.dentry = dget(mnt->mnt_root);
schedule_delayed_work(&nfs_automount_task, nfs_mountpoint_expiry_timeout);
Index: b/fs/nfs/nfs4proc.c
===================================================================
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -304,8 +304,7 @@ static void nfs4_opendata_free(struct kr
nfs4_put_open_state(p->state);
nfs4_put_state_owner(p->owner);
dput(p->dir);
- dput(p->path.dentry);
- mntput(p->path.mnt);
+ path_put(&p->path);
kfree(p);
}
@@ -1213,8 +1212,7 @@ static void nfs4_free_closedata(void *da
nfs4_put_open_state(calldata->state);
nfs_free_seqid(calldata->arg.seqid);
nfs4_put_state_owner(sp);
- dput(calldata->path.dentry);
- mntput(calldata->path.mnt);
+ path_put(&calldata->path);
kfree(calldata);
}
next prev parent reply other threads:[~2008-04-28 14:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 16:37 [PATCH 0/3] Some more path_{get,put}() cleanups Jan Blunck
2008-04-28 16:37 ` [PATCH 1/3] VFS: " Jan Blunck
2008-04-28 16:37 ` Jan Blunck [this message]
2008-04-28 16:37 ` [PATCH 3/3] AutoFS: " Jan Blunck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080428163732.072893435@T61.localnet \
--to=jblunck@suse.de \
--cc=Trond.Myklebust@netapp.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox