From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Roel Kluin <12o3l@tiscali.nl>, Ben Dooks <ben@simtec.co.uk>
Cc: Linux-arm <linux-arm-kernel@lists.arm.linux.org.uk>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] ARM: ax88796: platform_get_irq() may return signed unnoticed
Date: Mon, 28 Apr 2008 21:09:59 +0100 [thread overview]
Message-ID: <20080428200958.GF31100@flint.arm.linux.org.uk> (raw)
In-Reply-To: <480FAED6.7080407@tiscali.nl>
On Wed, Apr 23, 2008 at 11:49:10PM +0200, Roel Kluin wrote:
> similarly,
At the top of the file, it says:
* Copyright 2005,2007 Simtec Electronics
* Ben Dooks <ben@simtec.co.uk>
So adding Ben.
> ---
> dev->irq is unsigned, platform_get_irq() may return signed unnoticed
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/drivers/net/ax88796.c b/drivers/net/ax88796.c
> index 194949a..26a735a 100644
> --- a/drivers/net/ax88796.c
> +++ b/drivers/net/ax88796.c
> @@ -838,10 +838,10 @@ static int ax_probe(struct platform_device *pdev)
>
> /* find the platform resources */
>
> - dev->irq = platform_get_irq(pdev, 0);
> - if (dev->irq < 0) {
> + ret = platform_get_irq(pdev, 0);
> + dev->irq = ret;
> + if (ret < 0) {
> dev_err(&pdev->dev, "no IRQ specified\n");
> - ret = -ENXIO;
> goto exit_mem;
> }
>
>
>
> -------------------------------------------------------------------
> List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
> FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php
> Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php
next prev parent reply other threads:[~2008-04-28 20:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 21:44 [PATCH] ARM: am79c961a: platform_get_irq() may return signed unnoticed Roel Kluin
2008-04-23 21:49 ` [PATCH 2/2] ARM: ax88796: " Roel Kluin
2008-04-28 20:09 ` Russell King - ARM Linux [this message]
2008-04-24 6:11 ` [PATCH] ARM: am79c961a: " Uwe Kleine-König
2008-04-29 5:59 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080428200958.GF31100@flint.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=12o3l@tiscali.nl \
--cc=ben@simtec.co.uk \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox