From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Adrian Bunk <bunk@kernel.org>, Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Alexander van Heukelum <heukelum@mailshack.com>,
jdike@addtoit.com
Subject: Re: [2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline
Date: Tue, 29 Apr 2008 02:12:02 +0100 [thread overview]
Message-ID: <20080429011202.GH5882@ZenIV.linux.org.uk> (raw)
In-Reply-To: <alpine.LFD.1.10.0804281736230.3119@woody.linux-foundation.org>
On Mon, Apr 28, 2008 at 05:41:11PM -0700, Linus Torvalds wrote:
> There is NO WAY IN HELL this function shouldn't be inlined, and it doesn't
> matter a whit if some users outside of this file then also want the
> non-inlined version.
AFAICS, it's a gcc bug. We have
extern struct block_device *I_BDEV(struct inode *inode);
followed by
inline struct block_device *I_BDEV(struct inode *inode)
{
...
}
and presence of declaration with extern within the same translation unit
means that definition we have here is an external one, per 6.7.4. It's
perfectly legitimate and gcc has no business complaining about inline
here; moreover, example in 6.7.4(7) is essentially the same thing...
next prev parent reply other threads:[~2008-04-29 1:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-24 21:57 [git pull] generic bitops Ingo Molnar
2008-04-24 22:14 ` Linus Torvalds
2008-04-24 22:41 ` Harvey Harrison
2008-04-25 11:12 ` [PATCH] x86, bitops: select the generic bitmap search functions Alexander van Heukelum
2008-04-26 15:15 ` [git pull] generic bitops, take 2 Ingo Molnar
2008-04-26 17:03 ` Linus Torvalds
2008-04-26 17:22 ` Ingo Molnar
2008-04-26 17:28 ` Ingo Molnar
2008-04-26 17:50 ` [git pull] generic bitops, take 3 Ingo Molnar
2008-04-26 17:32 ` [git pull] generic bitops, take 2 Sam Ravnborg
2008-04-26 17:51 ` Miklos Vajna
2008-04-28 15:38 ` [2.6 patch] mm/filemap.c:generic_write_checks() mustn't be inline Adrian Bunk
2008-04-28 15:38 ` [2.6 patch] fs/buffer.c:init_buffer() " Adrian Bunk
2008-04-28 16:01 ` Linus Torvalds
2008-04-28 16:48 ` Adrian Bunk
2008-04-28 16:58 ` Linus Torvalds
2008-04-28 15:38 ` [2.6 patch] fs/block_dev.c:I_BDEV() " Adrian Bunk
2008-04-29 0:41 ` Linus Torvalds
2008-04-29 1:12 ` Al Viro [this message]
2008-04-29 1:21 ` Linus Torvalds
2008-04-29 2:32 ` Jeff Dike
2008-04-29 4:57 ` Sam Ravnborg
2008-04-29 8:06 ` Adrian Bunk
2008-04-29 8:17 ` Sam Ravnborg
2008-04-29 9:03 ` Adrian Bunk
2008-04-28 15:38 ` [2.6 patch] block/blk-barrier.c:blk_ordered_cur_seq() " Adrian Bunk
2008-04-29 7:46 ` Jens Axboe
2008-04-28 15:38 ` [2.6 patch] net/ipv4/ip_output.c:ip_send_check() " Adrian Bunk
2008-04-28 15:38 ` [2.6 patch] reiserfs: some functions " Adrian Bunk
2008-04-29 22:43 ` Edward Shishkin
2008-04-28 15:38 ` [2.6 patch] fs/udf/partition.c:udf_get_pblock() " Adrian Bunk
2008-04-28 16:47 ` Jan Kara
2008-04-28 17:26 ` [git pull] generic bitops, take 2 Jeff Dike
2008-04-26 17:34 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080429011202.GH5882@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=heukelum@mailshack.com \
--cc=hpa@zytor.com \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox