From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757223AbYD2Cdk (ORCPT ); Mon, 28 Apr 2008 22:33:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752485AbYD2Cd3 (ORCPT ); Mon, 28 Apr 2008 22:33:29 -0400 Received: from saraswathi.solana.com ([198.99.130.12]:33009 "EHLO saraswathi.solana.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752269AbYD2Cd3 (ORCPT ); Mon, 28 Apr 2008 22:33:29 -0400 Date: Mon, 28 Apr 2008 22:32:17 -0400 From: Jeff Dike To: Linus Torvalds Cc: Adrian Bunk , Ingo Molnar , Linux Kernel Mailing List , Andrew Morton , Thomas Gleixner , "H. Peter Anvin" , Alexander van Heukelum Subject: Re: [2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline Message-ID: <20080429023217.GA15676@c2.user-mode-linux.org> References: <20080424215739.GA32378@elte.hu> <20080426151516.GA27894@elte.hu> <20080426172222.GD17345@elte.hu> <20080428153831.GC2813@cs181133002.pp.htv.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 28, 2008 at 05:41:11PM -0700, Linus Torvalds wrote: > So just removing the inline is simply not acceptable any more, since it > just implies total and utter breakage of the compiler. At some point you > just have to say: "That is sh*t", and not take it any more. > > What is UML doing to trigger this? Beats the crap out of me. These things are very generic code from UML's point of view. Jeff -- Work email - jdike at linux dot intel dot com