From: Andrew Morton <akpm@linux-foundation.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org, mingo@redhat.com
Subject: Re: [PATCH] toshiba: Use ioremap_cached
Date: Tue, 29 Apr 2008 08:14:08 -0700 [thread overview]
Message-ID: <20080429081408.c9dc6b4f.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080429141559.GB26461@elte.hu>
On Tue, 29 Apr 2008 16:15:59 +0200 Ingo Molnar <mingo@elte.hu> wrote:
>
> * Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
>
> > The switch of ioremap to default to uncached doesn't break this driver
> > but it does needlessly slow it down as BIOS space is cachable and this
> > driver is quite happy scanning cached ROM space.
> >
> > Signed-off-by: Alan Cox <alan@redhat.com>
>
> Acked-by: Ingo Molnar <mingo@elte.hu>
>
> i suspect this shouldnt go via x86.git but i've queued it up to track
> it.
Please don't "queue things up to track them". Just queue them up to merge
them, or don't queue them at all.
Because if you queue it up then I will not. If you later for some reason
unqueue it then volia, it is lost. We should aim to avoid having multiple
copies of a patch sitting around the place.
I shall not merge this patch - it is yours.
> Is there an active maintainer for this file?
drivers/char/*? Very rarely maintained. git-whatchanged tells the story
on this one: no.
next prev parent reply other threads:[~2008-04-29 15:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 13:20 [PATCH] toshiba: Use ioremap_cached Alan Cox
2008-04-29 14:15 ` Ingo Molnar
2008-04-29 15:14 ` Andrew Morton [this message]
2008-04-29 15:23 ` Ingo Molnar
2008-04-29 15:37 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080429081408.c9dc6b4f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox