* rtc_valid_tm doesn't check tm_wday
@ 2008-04-29 6:44 Uwe Kleine-König
2008-04-29 10:40 ` David Brownell
0 siblings, 1 reply; 3+ messages in thread
From: Uwe Kleine-König @ 2008-04-29 6:44 UTC (permalink / raw)
To: Alessandro Zummo, David Brownell; +Cc: linux-kernel
Hello,
I'm currently writing an rtc driver and want to use rtc_valid_tm to
assert to have a valid date before writing it to the rtc.
Now I wonder why rtc_valid_tm doesn't check tm_wday for being in the
range [0 .. 6]. Is there a reason? I could imagine that you want to
be able to check paritial "struct rtc_time"s, too.
So should I check tm_wday myself?
Best regards
Uwe
--
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: rtc_valid_tm doesn't check tm_wday
2008-04-29 6:44 rtc_valid_tm doesn't check tm_wday Uwe Kleine-König
@ 2008-04-29 10:40 ` David Brownell
2008-04-29 12:22 ` Uwe Kleine-König
0 siblings, 1 reply; 3+ messages in thread
From: David Brownell @ 2008-04-29 10:40 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: Alessandro Zummo, linux-kernel
On Monday 28 April 2008, Uwe Kleine-König wrote:
> Hello,
>
> I'm currently writing an rtc driver and want to use rtc_valid_tm to
> assert to have a valid date before writing it to the rtc.
>
> Now I wonder why rtc_valid_tm doesn't check tm_wday for being in the
> range [0 .. 6]. Is there a reason?
As far as I know, the kernel doesn't use tm_wday, tm_yday, or
tm_isdst ... so none of those fields are expected to be valid.
See the rtc(4) manpage.
- Dave
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: rtc_valid_tm doesn't check tm_wday
2008-04-29 10:40 ` David Brownell
@ 2008-04-29 12:22 ` Uwe Kleine-König
0 siblings, 0 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2008-04-29 12:22 UTC (permalink / raw)
To: David Brownell; +Cc: Alessandro Zummo, linux-kernel
Hello Dave,
David Brownell wrote:
> On Monday 28 April 2008, Uwe Kleine-König wrote:
> > Hello,
> >
> > I'm currently writing an rtc driver and want to use rtc_valid_tm to
> > assert to have a valid date before writing it to the rtc.
> >
> > Now I wonder why rtc_valid_tm doesn't check tm_wday for being in the
> > range [0 .. 6]. Is there a reason?
>
> As far as I know, the kernel doesn't use tm_wday, tm_yday, or
> tm_isdst ... so none of those fields are expected to be valid.
> See the rtc(4) manpage.
Thanks.
I still want to write the correct value to the rtc, so I will assert
dirctly in the driver that it's valid.
Best regards,
Uwe
--
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-04-29 12:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-29 6:44 rtc_valid_tm doesn't check tm_wday Uwe Kleine-König
2008-04-29 10:40 ` David Brownell
2008-04-29 12:22 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox