From: Andrew Morton <akpm@linux-foundation.org>
To: Russ Anderson <rja@sgi.com>
Cc: linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
torvalds@linux-foundation.org, tony.luck@intel.com,
clameter@sgi.com
Subject: Re: [PATCH 1/2] mm: Avoid putting a bad page back on the LRU
Date: Tue, 29 Apr 2008 14:33:29 -0700 [thread overview]
Message-ID: <20080429143329.3a17ef91.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080428192358.GB14629@sgi.com>
On Mon, 28 Apr 2008 14:23:58 -0500
Russ Anderson <rja@sgi.com> wrote:
> --- test.orig/include/linux/kernel.h 2008-04-25 15:22:07.640501421 -0500
> +++ test/include/linux/kernel.h 2008-04-25 15:42:02.826266036 -0500
> @@ -412,6 +412,7 @@ struct sysinfo {
> unsigned long totalhigh; /* Total high memory size */
> unsigned long freehigh; /* Available high memory size */
> unsigned int mem_unit; /* Memory unit size in bytes */
> + unsigned int badpages; /* Number of bad (PG_memerror) pages */
> char _f[20-2*sizeof(long)-sizeof(int)]; /* Padding: libc5 uses this.. */
> };
eek. sys_sysinfo() copies this structure out to userspace verbatim.
Increasing its size by four bytes will cause memory scribbles in userspace
applications.
That's fixable by suitably adjusting sysinfo._f, but given the lack of
version information in the sysinfo struct, I'm not sure how useful this
change really is.
next prev parent reply other threads:[~2008-04-29 21:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 19:23 [PATCH 1/2] mm: Avoid putting a bad page back on the LRU Russ Anderson
2008-04-28 19:39 ` Christoph Lameter
2008-04-29 21:33 ` Andrew Morton [this message]
2008-04-29 14:17 ` Arjan van de Ven
2008-04-29 21:47 ` Russ Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080429143329.3a17ef91.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rja@sgi.com \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox