From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756463AbYD2Poc (ORCPT ); Tue, 29 Apr 2008 11:44:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753914AbYD2PoX (ORCPT ); Tue, 29 Apr 2008 11:44:23 -0400 Received: from fg-out-1718.google.com ([72.14.220.159]:35652 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751631AbYD2PoW (ORCPT ); Tue, 29 Apr 2008 11:44:22 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:subject:message-id:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=TlaMDaZkacYxoI4AHQOLgntJKWqxo/rsh9JKK2zzwuzqF/nlVLFbA6A2djusgGe/ZnRqUR/Oq8JAA8VYerSzUwxSKworyWriNgbrwbDJzOig9uRS//R7s4zkVKjeg9xXnjlMRPeWatJninFq2IA30YuxO/u6vnFoSlawQp9mJic= Date: Tue, 29 Apr 2008 19:43:30 +0400 From: Cyrill Gorcunov To: Ingo Molnar , "H. Peter Anvin" , David Woodhouse , LKML , Thomas Gleixner Subject: Re: [PATCH] x86: vm86 - hide X86_VM_MASK from userland programs v2 Message-ID: <20080429154330.GC6837@cvg> References: <20080424144120.GA7717@cvg> <4810CC2F.3010600@zytor.com> <20080428182323.GD1685@elte.hu> <20080428192039.GA10267@elte.hu> <20080429152947.GB6837@cvg> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080429152947.GB6837@cvg> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Cyrill Gorcunov - Tue, Apr 29, 2008 at 07:29:47PM +0400] | [Ingo Molnar - Mon, Apr 28, 2008 at 09:20:39PM +0200] | | | | Cyrill, | | | | randconfig testing in x86.git found a build bug and i bisected it to | | your patch - output is below. Config attached. Looks like some config | | file dependency hell problem? The dependencies there definitely need a | | good look and a handful of cleanups as well. | | | | Ingo | | | | ---------------------> | | In file included from include/asm/vm86.h:139, | | from include/asm/processor.h:11, | | from include/asm/atomic_32.h:6, | | from include/asm/atomic.h:3, | | from include/linux/crypto.h:21, | | from arch/x86/kernel/asm-offsets_32.c:8, | | from arch/x86/kernel/asm-offsets.c:3: | | include/asm/ptrace.h: In function 'user_mode_vm': | | include/asm/ptrace.h:207: error: 'X86_VM_MASK' undeclared (first use in this function) | | include/asm/ptrace.h:207: error: (Each undeclared identifier is reported only once | | include/asm/ptrace.h:207: error: for each function it appears in.) | | include/asm/ptrace.h: In function 'v8086_mode': | | include/asm/ptrace.h:217: error: 'X86_VM_MASK' undeclared (first use in this function) | | Argh! Ingo, it seems that the real problem was introdused by | | commit 8fc37f2c474b8ea61186fd77193324845432447b | Author: Thomas Gleixner | Date: Tue Oct 23 22:37:24 2007 +0200 | | x86: merge ptrace_32/64.h | | Signed-off-by: Ingo Molnar | Signed-off-by: Thomas Gleixner | | with this patch we have included only | if __i386__ defined *BUT* X86_VM_MASK is tried to be | used *without* __386__ being checked (as example - ptrace.h:user_mode_vm). | I'm not sure how to properly hanle this situation. But will take a look. | | So I suggest you drop my last patch (which moves X86_VM_MASK | into __KERNEL__ section) for a while. I'll recheck all | this stuff later (too busy now). | | - Cyrill - Thomas, could you take a look please - is my suspicious wrong? - Cyrill -