Re: patch driver-core-warn-about-duplicate-driver-names-on-the-same-bus.patch added to gregkh-2.6 tree

Stas Sergeev
2008-05-02T15:38:24Z

Hello.

Takashi Iwai wrote:
> And this won't work in most cases. People don't want to replace the
> existing pcspkr driver with snd-pcsp. They don't want to load the
> sound subsystem on their systems just because of beep.
Why should they? They may just stick with
pcspkr driver if they want.

> If you compare pcspkr.c and pcsp_input.c, it's found that the only
> essential difference is the additional check at the head of the event
> handler:
> if (atomic_read(&pcsp_chip.timer_active) || !pcsp_chip.pcspkr)
> return 0;
> If this can be added dynamically to input pcspkr.c, no big point to
> have duped codes.
Another point is PM callbacks. Somehow
snd-pcsp will have to register them with
pcspkr.

> Distros usually make input-pcspkr as built-in, not as module.
> So, snd-pcsp is practically unusable on standard kernels of major
> distros as is, unfortunately...
Oh, that's really bad, I didn't know
they do. For what reason? And how then
people disable the beeps?
Btw, could you please name a few? At
least Fedora has it as a module.

OK, I'll see about using pcspkr.c. But
it looks like the needed hooks won't be
too small (call to disable the beeps and
a call to register the PM callbacks) and
unlikely to be accepted upstream...