public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: Justin Forbes <jmforbes@linuxtx.org>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Dave Jones <davej@redhat.com>,
	Chuck Wolber <chuckw@quantumlinux.com>,
	Chris Wedgwood <reviews@ml.cw.f00f.org>,
	Michael Krufky <mkrufky@linuxtv.org>,
	Chuck Ebbert <cebbert@redhat.com>,
	Domenico Andreoli <cavokz@gmail.com>,
	torvalds@linux-foundation.org, akpm@linux-foundation.org,
	alan@lxorguk.ukuu.org.uk, linux-wireless@vger.kernel.org,
	bcm43xx-dev@lists.berlios.de, Michael Buesch <mb@bu3sch.de>,
	"John W. Linville" <linville@tuxdriver.com>
Subject: [23/37] b43: Workaround invalid bluetooth settings
Date: Tue, 29 Apr 2008 10:18:50 -0700	[thread overview]
Message-ID: <20080429171850.GX14724@suse.de> (raw)
In-Reply-To: <20080429171730.GA14724@suse.de>

[-- Attachment #1: b43-workaround-invalid-bluetooth-settings.patch --]
[-- Type: text/plain, Size: 2979 bytes --]

2.6.25-stable review patch.  If anyone has any objections, please let us
know.

------------------
From: Michael Buesch <mb@bu3sch.de>

commit 1855ba7812dbd294fcfc083dc7d3b14d3b1f38db upstream.

This adds a workaround for invalid bluetooth SPROM settings
on ASUS PCI cards.
This will stop the microcode from poking with the BT GPIO line.
This fixes data transmission on this device, as the BT GPIO line
is used for something TX related on this device
(probably the power amplifier or the radio).
This also adds a modparam knob to help debugging this in the future,
as more devices with this bug may show up.

Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>


---
 drivers/net/wireless/b43/main.c |   23 +++++++++++++++++++++--
 1 file changed, 21 insertions(+), 2 deletions(-)

--- a/drivers/net/wireless/b43/main.c
+++ b/drivers/net/wireless/b43/main.c
@@ -78,6 +78,11 @@ static int modparam_nohwcrypt;
 module_param_named(nohwcrypt, modparam_nohwcrypt, int, 0444);
 MODULE_PARM_DESC(nohwcrypt, "Disable hardware encryption.");
 
+static int modparam_btcoex = 1;
+module_param_named(btcoex, modparam_btcoex, int, 0444);
+MODULE_PARM_DESC(btcoex, "Enable Bluetooth coexistance (default on)");
+
+
 static const struct ssb_device_id b43_ssb_tbl[] = {
 	SSB_DEVICE(SSB_VENDOR_BROADCOM, SSB_DEV_80211, 5),
 	SSB_DEVICE(SSB_VENDOR_BROADCOM, SSB_DEV_80211, 6),
@@ -3339,6 +3344,8 @@ static void b43_bluetooth_coext_enable(s
 	struct ssb_sprom *sprom = &dev->dev->bus->sprom;
 	u32 hf;
 
+	if (!modparam_btcoex)
+		return;
 	if (!(sprom->boardflags_lo & B43_BFL_BTCOEXIST))
 		return;
 	if (dev->phy.type != B43_PHYTYPE_B && !dev->phy.gmode)
@@ -3350,11 +3357,13 @@ static void b43_bluetooth_coext_enable(s
 	else
 		hf |= B43_HF_BTCOEX;
 	b43_hf_write(dev, hf);
-	//TODO
 }
 
 static void b43_bluetooth_coext_disable(struct b43_wldev *dev)
-{				//TODO
+{
+	if (!modparam_btcoex)
+		return;
+	//TODO
 }
 
 static void b43_imcfglo_timeouts_workaround(struct b43_wldev *dev)
@@ -4002,6 +4011,8 @@ static int b43_one_core_attach(struct ss
 
 static void b43_sprom_fixup(struct ssb_bus *bus)
 {
+	struct pci_dev *pdev;
+
 	/* boardflags workarounds */
 	if (bus->boardinfo.vendor == SSB_BOARDVENDOR_DELL &&
 	    bus->chip_id == 0x4301 && bus->boardinfo.rev == 0x74)
@@ -4009,6 +4020,14 @@ static void b43_sprom_fixup(struct ssb_b
 	if (bus->boardinfo.vendor == PCI_VENDOR_ID_APPLE &&
 	    bus->boardinfo.type == 0x4E && bus->boardinfo.rev > 0x40)
 		bus->sprom.boardflags_lo |= B43_BFL_PACTRL;
+	if (bus->bustype == SSB_BUSTYPE_PCI) {
+		pdev = bus->host_pci;
+		if (pdev->vendor == PCI_VENDOR_ID_BROADCOM &&
+		    pdev->device == 0x4318 &&
+		    pdev->subsystem_vendor == PCI_VENDOR_ID_ASUSTEK &&
+		    pdev->subsystem_device == 0x100F)
+			bus->sprom.boardflags_lo &= ~B43_BFL_BTCOEXIST;
+	}
 }
 
 static void b43_wireless_exit(struct ssb_device *dev, struct b43_wl *wl)

-- 

  parent reply	other threads:[~2008-04-29 17:29 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080429171222.073929148@mini.kroah.org>
2008-04-29 17:17 ` [00/37] 2.6.25-stable review Greg KH
2008-04-29 17:17   ` [01/37] USB: log an error message when USB enumeration fails Greg KH
2008-04-29 17:17   ` [02/37] USB: Add HP hs2300 Broadband Wireless Module to sierra.c Greg KH
2008-04-29 17:17   ` [03/37] JFFS2: Fix free space leak with in-band cleanmarkers Greg KH
2008-04-29 17:18   ` [04/37] tg3: 5701 DMA corruption fix Greg KH
2008-04-29 17:18   ` [05/37] tcp: tcp_probe buffer overflow and incorrect return value Greg KH
2008-04-29 17:18   ` [07/37] RTNETLINK: Fix bogus ASSERT_RTNL warning Greg KH
2008-04-29 17:18   ` [08/37] rose: Socket lock was not released before returning to user space Greg KH
2008-04-29 17:18   ` [09/37] net: Fix wrong interpretation of some copy_to_user() results Greg KH
2008-04-29 17:18   ` [10/37] IPSEC: Fix catch-22 with algorithm IDs above 31 Greg KH
2008-04-29 17:18   ` [11/37] USB: OHCI: fix bug in controller resume Greg KH
2008-04-29 17:18   ` [12/37] dm snapshot: fix chunksize sector conversion Greg KH
2008-04-29 17:18   ` [13/37] cgroup: fix a race condition in manipulating tsk->cg_list Greg KH
2008-04-29 17:18   ` [14/37] RDMA/nes: Free IRQ before killing tasklet Greg KH
2008-04-29 17:18   ` [15/37] V4L: Fix VIDIOCGAP corruption in ivtv Greg KH
2008-04-29 17:18   ` [16/37] V4L: tea5761: bugzilla #10462: tea5761 autodetection code were broken Greg KH
2008-04-29 17:18   ` [17/37] V4L: cx88: enable radio GPIO correctly Greg KH
2008-04-29 17:18   ` [18/37] S2io: Fix memory leak during free_tx_buffers Greg KH
2008-04-29 17:18   ` [19/37] S2io: Version update for memory leak fix " Greg KH
2008-04-29 17:18   ` [20/37] SELinux: no BUG_ON(!ss_initialized) in selinux_clone_mnt_opts Greg KH
2008-04-29 17:18   ` [21/37] x86, pci: fix off-by-one errors in some pirq warnings Greg KH
2008-04-29 17:18   ` [22/37] ssb: Fix all-ones boardflags Greg KH
2008-04-29 17:18   ` Greg KH [this message]
2008-04-29 17:18   ` [24/37] b43: Add more btcoexist workarounds Greg KH
2008-04-29 17:18   ` [25/37] b43: Workaround DMA quirks Greg KH
2008-04-29 17:18   ` [26/37] tehuti: check register size (CVE-2008-1675) Greg KH
2008-04-29 17:19   ` [27/37] tehuti: move ioctl perm check closer to function start (CVE-2008-1675) Greg KH
2008-04-29 18:13     ` Alan Cox
2008-04-29 18:55       ` Greg KH
2008-04-29 19:02         ` Linus Torvalds
2008-04-30 16:39           ` [stable] " Greg KH
2008-04-29 17:19   ` [28/37] aio: io_getevents() should return if io_destroy() is invoked Greg KH
2008-04-29 17:19   ` [29/37] rtc-pcf8583 build fix Greg KH
2008-04-29 17:19   ` [30/37] dz: test after postfix decrement fails in dz_console_putchar() Greg KH
2008-04-29 17:19   ` [31/37] mm: fix possible off-by-one in walk_pte_range() Greg KH
2008-04-29 17:19   ` [32/37] hrtimer: timeout too long when using HRTIMER_CB_SOFTIRQ Greg KH
2008-04-29 17:19   ` [33/37] RDMA/nes: Fix adapter reset after PXE boot Greg KH
2008-04-29 17:19   ` [34/37] SCSI: qla2xxx: Correct regression in relogin code Greg KH
2008-04-29 17:19   ` [35/37] alpha: unbreak OSF/1 (a.out) binaries Greg KH
2008-04-29 17:19   ` [36/37] x86: Fix 32-bit x86 MSI-X allocation leakage Greg KH
2008-04-29 17:19   ` [37/37] hrtimer: raise softirq unlocked to avoid circular lock dependency Greg KH
2008-04-30  7:58   ` [00/37] 2.6.25-stable review Andre Noll
2008-05-01  0:25     ` [stable] " Chris Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080429171850.GX14724@suse.de \
    --to=gregkh@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bcm43xx-dev@lists.berlios.de \
    --cc=cavokz@gmail.com \
    --cc=cebbert@redhat.com \
    --cc=chuckw@quantumlinux.com \
    --cc=davej@redhat.com \
    --cc=jmforbes@linuxtx.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mb@bu3sch.de \
    --cc=mkrufky@linuxtv.org \
    --cc=rdunlap@xenotime.net \
    --cc=reviews@ml.cw.f00f.org \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox