public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org, jejb@kernel.org
Cc: Justin Forbes <jmforbes@linuxtx.org>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Dave Jones <davej@redhat.com>,
	Chuck Wolber <chuckw@quantumlinux.com>,
	Chris Wedgwood <reviews@ml.cw.f00f.org>,
	Michael Krufky <mkrufky@linuxtv.org>,
	Chuck Ebbert <cebbert@redhat.com>,
	Domenico Andreoli <cavokz@gmail.com>,
	torvalds@linux-foundation.org, akpm@linux-foundation.org,
	alan@lxorguk.ukuu.org.uk, Chien Tung <ctung@neteffect.com>,
	Roland Dreier <rolandd@cisco.com>
Subject: [33/37] RDMA/nes: Fix adapter reset after PXE boot
Date: Tue, 29 Apr 2008 10:19:17 -0700	[thread overview]
Message-ID: <20080429171917.GH14724@suse.de> (raw)
In-Reply-To: <20080429171730.GA14724@suse.de>

[-- Attachment #1: rdma-nes-fix-adapter-reset-after-pxe-boot.patch --]
[-- Type: text/plain, Size: 2476 bytes --]

2.6.25-stable review patch.  If anyone has any objections, please let us
know.

------------------
From: Chien Tung <ctung@neteffect.com>

commit: bc5698f3ecc9587e1edb343a2878f8d228c49e0e upstream

After PXE boot, the iw_nes driver does a full reset to ensure the card
is in a clean state.  However, it doesn't wait for firmware to
complete its work before issuing a port reset to enable the ports,
which leads to problems bringing up the ports.

The solution is to wait for firmware to complete its work before
proceeding with port reset.

This bug was flagged by Roland Dreier <rolandd@cisco.com>.

Signed-off-by: Chien Tung <ctung@neteffect.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/infiniband/hw/nes/nes_cm.c |    6 ++++--
 drivers/infiniband/hw/nes/nes_hw.c |   20 +++++++++-----------
 2 files changed, 13 insertions(+), 13 deletions(-)

--- a/drivers/infiniband/hw/nes/nes_cm.c
+++ b/drivers/infiniband/hw/nes/nes_cm.c
@@ -1834,8 +1834,10 @@ int mini_cm_recv_pkt(struct nes_cm_core 
 	nfo.rem_addr = ntohl(iph->saddr);
 	nfo.rem_port = ntohs(tcph->source);
 
-	nes_debug(NES_DBG_CM, "Received packet: dest=0x%08X:0x%04X src=0x%08X:0x%04X\n",
-			iph->daddr, tcph->dest, iph->saddr, tcph->source);
+	nes_debug(NES_DBG_CM, "Received packet: dest=" NIPQUAD_FMT
+		  ":0x%04X src=" NIPQUAD_FMT ":0x%04X\n",
+		  NIPQUAD(iph->daddr), tcph->dest,
+		  NIPQUAD(iph->saddr), tcph->source);
 
 	/* note: this call is going to increment cm_node ref count */
 	cm_node = find_node(cm_core,
--- a/drivers/infiniband/hw/nes/nes_hw.c
+++ b/drivers/infiniband/hw/nes/nes_hw.c
@@ -625,6 +625,15 @@ unsigned int nes_reset_adapter_ne020(str
 			nes_debug(NES_DBG_INIT, "Did not see full soft reset done.\n");
 			return 0;
 		}
+
+		i = 0;
+		while ((nes_read_indexed(nesdev, NES_IDX_INT_CPU_STATUS) != 0x80) && i++ < 10000)
+			mdelay(1);
+		if (i >= 10000) {
+			printk(KERN_ERR PFX "Internal CPU not ready, status = %02X\n",
+			       nes_read_indexed(nesdev, NES_IDX_INT_CPU_STATUS));
+			return 0;
+		}
 	}
 
 	/* port reset */
@@ -673,17 +682,6 @@ unsigned int nes_reset_adapter_ne020(str
 		}
 	}
 
-
-
-	i = 0;
-	while ((nes_read_indexed(nesdev, NES_IDX_INT_CPU_STATUS) != 0x80) && i++ < 10000)
-		mdelay(1);
-	if (i >= 10000) {
-		printk(KERN_ERR PFX "Internal CPU not ready, status = %02X\n",
-				nes_read_indexed(nesdev, NES_IDX_INT_CPU_STATUS));
-		return 0;
-	}
-
 	return port_count;
 }
 

-- 

  parent reply	other threads:[~2008-04-29 17:33 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080429171222.073929148@mini.kroah.org>
2008-04-29 17:17 ` [00/37] 2.6.25-stable review Greg KH
2008-04-29 17:17   ` [01/37] USB: log an error message when USB enumeration fails Greg KH
2008-04-29 17:17   ` [02/37] USB: Add HP hs2300 Broadband Wireless Module to sierra.c Greg KH
2008-04-29 17:17   ` [03/37] JFFS2: Fix free space leak with in-band cleanmarkers Greg KH
2008-04-29 17:18   ` [04/37] tg3: 5701 DMA corruption fix Greg KH
2008-04-29 17:18   ` [05/37] tcp: tcp_probe buffer overflow and incorrect return value Greg KH
2008-04-29 17:18   ` [07/37] RTNETLINK: Fix bogus ASSERT_RTNL warning Greg KH
2008-04-29 17:18   ` [08/37] rose: Socket lock was not released before returning to user space Greg KH
2008-04-29 17:18   ` [09/37] net: Fix wrong interpretation of some copy_to_user() results Greg KH
2008-04-29 17:18   ` [10/37] IPSEC: Fix catch-22 with algorithm IDs above 31 Greg KH
2008-04-29 17:18   ` [11/37] USB: OHCI: fix bug in controller resume Greg KH
2008-04-29 17:18   ` [12/37] dm snapshot: fix chunksize sector conversion Greg KH
2008-04-29 17:18   ` [13/37] cgroup: fix a race condition in manipulating tsk->cg_list Greg KH
2008-04-29 17:18   ` [14/37] RDMA/nes: Free IRQ before killing tasklet Greg KH
2008-04-29 17:18   ` [15/37] V4L: Fix VIDIOCGAP corruption in ivtv Greg KH
2008-04-29 17:18   ` [16/37] V4L: tea5761: bugzilla #10462: tea5761 autodetection code were broken Greg KH
2008-04-29 17:18   ` [17/37] V4L: cx88: enable radio GPIO correctly Greg KH
2008-04-29 17:18   ` [18/37] S2io: Fix memory leak during free_tx_buffers Greg KH
2008-04-29 17:18   ` [19/37] S2io: Version update for memory leak fix " Greg KH
2008-04-29 17:18   ` [20/37] SELinux: no BUG_ON(!ss_initialized) in selinux_clone_mnt_opts Greg KH
2008-04-29 17:18   ` [21/37] x86, pci: fix off-by-one errors in some pirq warnings Greg KH
2008-04-29 17:18   ` [22/37] ssb: Fix all-ones boardflags Greg KH
2008-04-29 17:18   ` [23/37] b43: Workaround invalid bluetooth settings Greg KH
2008-04-29 17:18   ` [24/37] b43: Add more btcoexist workarounds Greg KH
2008-04-29 17:18   ` [25/37] b43: Workaround DMA quirks Greg KH
2008-04-29 17:18   ` [26/37] tehuti: check register size (CVE-2008-1675) Greg KH
2008-04-29 17:19   ` [27/37] tehuti: move ioctl perm check closer to function start (CVE-2008-1675) Greg KH
2008-04-29 18:13     ` Alan Cox
2008-04-29 18:55       ` Greg KH
2008-04-29 19:02         ` Linus Torvalds
2008-04-30 16:39           ` [stable] " Greg KH
2008-04-29 17:19   ` [28/37] aio: io_getevents() should return if io_destroy() is invoked Greg KH
2008-04-29 17:19   ` [29/37] rtc-pcf8583 build fix Greg KH
2008-04-29 17:19   ` [30/37] dz: test after postfix decrement fails in dz_console_putchar() Greg KH
2008-04-29 17:19   ` [31/37] mm: fix possible off-by-one in walk_pte_range() Greg KH
2008-04-29 17:19   ` [32/37] hrtimer: timeout too long when using HRTIMER_CB_SOFTIRQ Greg KH
2008-04-29 17:19   ` Greg KH [this message]
2008-04-29 17:19   ` [34/37] SCSI: qla2xxx: Correct regression in relogin code Greg KH
2008-04-29 17:19   ` [35/37] alpha: unbreak OSF/1 (a.out) binaries Greg KH
2008-04-29 17:19   ` [36/37] x86: Fix 32-bit x86 MSI-X allocation leakage Greg KH
2008-04-29 17:19   ` [37/37] hrtimer: raise softirq unlocked to avoid circular lock dependency Greg KH
2008-04-30  7:58   ` [00/37] 2.6.25-stable review Andre Noll
2008-05-01  0:25     ` [stable] " Chris Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080429171917.GH14724@suse.de \
    --to=gregkh@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=cavokz@gmail.com \
    --cc=cebbert@redhat.com \
    --cc=chuckw@quantumlinux.com \
    --cc=ctung@neteffect.com \
    --cc=davej@redhat.com \
    --cc=jejb@kernel.org \
    --cc=jmforbes@linuxtx.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkrufky@linuxtv.org \
    --cc=rdunlap@xenotime.net \
    --cc=reviews@ml.cw.f00f.org \
    --cc=rolandd@cisco.com \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox