public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org, jejb@kernel.org
Cc: Justin Forbes <jmforbes@linuxtx.org>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Dave Jones <davej@redhat.com>,
	Chuck Wolber <chuckw@quantumlinux.com>,
	Chris Wedgwood <reviews@ml.cw.f00f.org>,
	Michael Krufky <mkrufky@linuxtv.org>,
	Chuck Ebbert <cebbert@redhat.com>,
	Domenico Andreoli <cavokz@gmail.com>,
	torvalds@linux-foundation.org, akpm@linux-foundation.org,
	alan@lxorguk.ukuu.org.uk, Oliver Neukum <oliver@neukum.org>
Subject: [09/12] USB: remove broken usb-serial num_endpoints check
Date: Tue, 29 Apr 2008 11:49:56 -0700	[thread overview]
Message-ID: <20080429184956.GJ24199@suse.de> (raw)
In-Reply-To: <20080429184911.GA24199@suse.de>

[-- Attachment #1: usb-remove-broken-usb-serial-num_endpoints-check.patch --]
[-- Type: text/plain, Size: 1363 bytes --]

2.6.24-stable review patch.  If anyone has any objections, please let us
know.

------------------

From: Greg Kroah-Hartman <gregkh@suse.de>

commit: 07c3b1a1001614442c665570942a3107a722c314

The num_interrupt_in, num_bulk_in, and other checks in the usb-serial
code are just wrong, there are too many different devices out there with
different numbers of endpoints.  We need to just be sticking with the
device ids instead of trying to catch this kind of thing.  It broke too
many different devices.

This fixes a large number of usb-serial devices to get them working
properly again.


Cc: Oliver Neukum <oliver@neukum.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/usb/serial/usb-serial.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/usb/serial/usb-serial.c
+++ b/drivers/usb/serial/usb-serial.c
@@ -844,6 +844,7 @@ int usb_serial_probe(struct usb_interfac
 	serial->num_interrupt_in = num_interrupt_in;
 	serial->num_interrupt_out = num_interrupt_out;
 
+#if 0
 	/* check that the device meets the driver's requirements */
 	if ((type->num_interrupt_in != NUM_DONT_CARE &&
 				type->num_interrupt_in != num_interrupt_in)
@@ -857,6 +858,7 @@ int usb_serial_probe(struct usb_interfac
 		kfree(serial);
 		return -EIO;
 	}
+#endif
 
 	/* found all that we need */
 	dev_info(&interface->dev, "%s converter detected\n",

-- 

  parent reply	other threads:[~2008-04-29 18:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080429184543.308594866@mini.kroah.org>
2008-04-29 18:49 ` [00/12] 2.6.24-stable review Greg KH
2008-04-29 18:49   ` [01/12] splice: use mapping_gfp_mask Greg KH
2008-04-29 18:49   ` [02/12] fix oops on rmmod capidrv Greg KH
2008-04-29 18:49   ` [03/12] x86: Fix 32-bit x86 MSI-X allocation leakage Greg KH
2008-04-29 18:49   ` [04/12] tehuti: check register size (CVE-2008-1675) Greg KH
2008-04-29 18:49   ` [05/12] tehuti: move ioctl perm check closer to function start (CVE-2008-1675) Greg KH
2008-04-29 18:49   ` [06/12] USB: gadget: queue usb USB_CDC_GET_ENCAPSULATED_RESPONSE message Greg KH
2008-04-29 18:49   ` [07/12] JFFS2: Fix free space leak with in-band cleanmarkers Greg KH
2008-04-29 18:49   ` Greg KH [this message]
2008-04-29 18:50   ` [09/12] USB: remove broken usb-serial num_endpoints check Greg KH
2008-04-29 18:50   ` [10/12] V4L: Fix VIDIOCGAP corruption in ivtv Greg KH
2008-04-29 18:50   ` [11/12] V4L: cx88: enable radio GPIO correctly Greg KH
2008-04-29 18:50   ` [12/12] ISDN: Do not validate ISDN net device address prior to interface-up Greg KH
2008-04-29 21:27   ` [00/12] 2.6.24-stable review Jörg-Volker Peetz
2008-04-29 22:45     ` Willy Tarreau
2008-04-30  3:21     ` Darren Salt
2008-05-01  3:39       ` [stable] " Greg KH
2008-05-02 15:24         ` Darren Salt
2008-05-08 17:27           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080429184956.GJ24199@suse.de \
    --to=gregkh@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=cavokz@gmail.com \
    --cc=cebbert@redhat.com \
    --cc=chuckw@quantumlinux.com \
    --cc=davej@redhat.com \
    --cc=jejb@kernel.org \
    --cc=jmforbes@linuxtx.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkrufky@linuxtv.org \
    --cc=oliver@neukum.org \
    --cc=rdunlap@xenotime.net \
    --cc=reviews@ml.cw.f00f.org \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox