From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758454AbYD2T5e (ORCPT ); Tue, 29 Apr 2008 15:57:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752287AbYD2T5V (ORCPT ); Tue, 29 Apr 2008 15:57:21 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:54077 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752357AbYD2T5T (ORCPT ); Tue, 29 Apr 2008 15:57:19 -0400 Date: Tue, 29 Apr 2008 21:55:08 +0200 From: Ingo Molnar To: linux-kernel@vger.kernel.org Cc: Jens Axboe , Jeff Garzik , James Bottomley Subject: [bug - scsi/blk] -git, WARNING: at include/linux/blkdev.h:427 __blk_run_queue+0x74/0xa0() Message-ID: <20080429195508.GA30109@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org x86.git auto-testing found two new warnings below with latest -git: WARNING: at include/linux/blkdev.h:439 blk_remove_plug+0x69/0x80() WARNING: at include/linux/blkdev.h:427 __blk_run_queue+0x74/0xa0() one seems a relatively harmless init locking bug (unlocked access in a probe function), the other seems scarier as it happens in an irq handler and it likely would trigger multiple times if it wasnt a WARN_ON_ONCE(). Config and full log at: http://redhat.com/~mingo/misc/log-Tue_Apr_29_21_40_46_CEST_2008.bad http://redhat.com/~mingo/misc/config-Tue_Apr_29_21_40_46_CEST_2008.bad system booted up fine otherwise and the warnings did not trigger again. Ingo EXT3-fs: write access will be enabled during recovery. ------------[ cut here ]------------ WARNING: at include/linux/blkdev.h:427 __blk_run_queue+0x74/0xa0() Modules linked in: Pid: 0, comm: swapper Tainted: G W 2.6.25-sched-devel.git-x86-latest.git #2 [] warn_on_slowpath+0x59/0x80 [] ? cache_flusharray+0xb5/0x100 [] ? mempool_free_slab+0x13/0x20 [] ? poison_obj+0x2b/0x50 [] ? cache_free_debugcheck+0xce/0x240 [] ? mempool_free_slab+0x13/0x20 [] ? mempool_free+0x68/0xe0 [] ? mempool_free_slab+0x13/0x20 [] ? poison_obj+0x2b/0x50 [] ? cache_free_debugcheck+0xce/0x240 [] ? __freed_request+0xab/0xf0 [] ? scsi_pool_free_command+0x2d/0x40 [] __blk_run_queue+0x74/0xa0 [] blk_run_queue+0x36/0x80 [] scsi_run_queue+0x15f/0x300 [] ? scsi_put_command+0x6c/0x90 [] scsi_next_command+0x38/0x50 [] scsi_end_request+0x6f/0xb0 [] scsi_io_completion+0x97/0x410 [] scsi_finish_command+0x76/0x90 [] scsi_softirq_done+0x77/0xf0 [] blk_done_softirq+0x7a/0x90 [] __do_softirq+0x85/0x140 [] do_softirq+0xc2/0x100 [] ? handle_edge_irq+0x0/0xf0 [] irq_exit+0x3b/0x50 [] do_IRQ+0x81/0xc0 [] ? default_idle+0x0/0x80 [] ? default_idle+0x0/0x80 [] common_interrupt+0x28/0x30 [] ? default_idle+0x0/0x80 [] ? native_safe_halt+0xa/0x10 [] default_idle+0x53/0x80 [] cpu_idle+0x40/0x90 [] rest_init+0x48/0x50 [] start_kernel+0x26f/0x300 [] ? unknown_bootoption+0x0/0x210 [] ? mcount_call+0x5/0x9 [] i386_start_kernel+0xd/0x10 ======================= ---[ end trace e97bb6de0cc9400b ]--- kjournald starting. Commit interval 5 seconds EXT3-fs: recovery complete. ata2.01: configured for UDMA/33 ------------[ cut here ]------------ WARNING: at include/linux/blkdev.h:439 blk_remove_plug+0x69/0x80() Modules linked in: Pid: 1, comm: swapper Not tainted 2.6.25-sched-devel.git-x86-latest.git #2 [] warn_on_slowpath+0x59/0x80 [] ? mcount_call+0x5/0x9 [] ? blk_recalc_rq_segments+0xe/0x210 [] ? marker_probe_cb+0x37/0x80 [] ? elv_insert+0xe/0x160 [] ? ftrace_record_ip+0xeb/0x210 [] ? blk_remove_plug+0x9/0x80 [] ? ftrace_record_ip+0xeb/0x210 [] blk_remove_plug+0x69/0x80 [] __generic_unplug_device+0x19/0x30 [] blk_execute_rq_nowait+0x6a/0xa0 [] blk_execute_rq+0x5b/0xa0 [] ? blk_end_sync_rq+0x0/0x30 [] ? mcount_call+0x5/0x9 [] ? blk_queue_bounce+0xe/0x280 [] ? bio_hw_segments+0x9/0x30 [] ? blk_rq_bio_prep+0x30/0xc0 [] scsi_execute+0xcf/0xf0 [] scsi_execute_req+0x71/0xe0 [] scsi_probe_and_add_lun+0x19d/0x8d0 [] ? mutex_unlock+0xd/0x10 [] ? get_device+0x16/0x20 [] ? scsi_alloc_target+0x20c/0x2c0 [] ? scsi_complete_async_scans+0xc/0xc0 [] ? mcount_call+0x5/0x9 [] __scsi_add_device+0xe1/0xf0 [] ata_scsi_scan_host+0xdf/0x2a0 [] ata_host_register+0x271/0x290 [] ata_pci_sff_activate_host+0x9b/0x210 [] ? ata_sff_interrupt+0x0/0x230 [] ata_pci_sff_init_one+0xde/0x100 [] amd_init_one+0xd3/0x1c0 [] ? amd_init_one+0x0/0x1c0 [] pci_device_probe+0x5e/0x90 [] driver_probe_device+0x82/0x180 [] __driver_attach+0x72/0x80 [] bus_for_each_dev+0x49/0x70 [] driver_attach+0x1e/0x20 [] ? __driver_attach+0x0/0x80 [] bus_add_driver+0xab/0x210 [] ? pci_device_remove+0x0/0x40 [] driver_register+0x42/0xf0 [] __pci_register_driver+0x3e/0x90 [] amd_init+0x19/0x20 [] kernel_init+0x86/0x210 [] ? kernel_init+0x0/0x210 [] kernel_thread_helper+0x7/0x10 ======================= ---[ end trace e97bb6de0cc9400b ]--- scsi 0:0:0:0: Direct-Access ATA HDS722525VLAT80 V36O PQ: 0 ANSI: 5 sd 0:0:0:0: [sda] 488397168 512-byte hardware sectors (250059 MB)