From: Matthew Wilcox <matthew@wil.cx>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Bryan Wu <cooloney@kernel.org>,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
willy@debian.org, viro@zeniv.linux.org.uk,
uclinux-dist-devel@blackfin.uclinux.org,
"J. Bruce Fields" <bfields@fieldses.org>
Subject: Re: [LTP/VFS] fcntl SETLEASE fails on ramfs/tmpfs
Date: Tue, 29 Apr 2008 16:21:42 -0600 [thread overview]
Message-ID: <20080429222141.GD14976@parisc-linux.org> (raw)
In-Reply-To: <20080429135454.efebec8f.akpm@linux-foundation.org>
On Tue, Apr 29, 2008 at 01:54:54PM -0700, Andrew Morton wrote:
> I guess we should make the generic_setlease() heuristic smarter.
>
> Of course the _reason_ for that heuristic is uncommented and lost in time.
> And one wonders what locking prevents it from being totally racy, and if
> "none", what happens when the race hits. Sigh.
It's hardly "lost in time" when you can ask the original author.
If there are multiple processes with this file open, you can't place a
lease on it.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-04-29 22:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 3:42 [LTP/VFS] fcntl SETLEASE fails on ramfs/tmpfs Bryan Wu
2008-04-29 20:54 ` Andrew Morton
2008-04-29 21:42 ` J. Bruce Fields
2008-04-29 22:01 ` Mike Frysinger
2008-04-29 22:11 ` J. Bruce Fields
2008-04-29 22:15 ` Mike Frysinger
2008-04-29 23:21 ` david m. richter
2008-04-30 17:50 ` J. Bruce Fields
2008-04-30 18:14 ` david m. richter
2008-05-01 6:24 ` Al Viro
2008-05-02 22:22 ` J. Bruce Fields
2008-04-29 22:21 ` Matthew Wilcox [this message]
2008-05-01 6:33 ` Al Viro
2008-05-02 22:26 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080429222141.GD14976@parisc-linux.org \
--to=matthew@wil.cx \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=cooloney@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox