Re: [patch, -git] media/video/sound build fix, TEA5761/TEA5767

Takashi Iwai
2008-04-30T12:05:10Z

At Wed, 30 Apr 2008 13:13:37 +0200,
Ingo Molnar wrote:
>
>
> * Ingo Molnar <mingo@elte.hu> wrote:
>
> > x86.git randconfig testing found the following new build error in
> > latest -git:
>
> updated fix below - another randconfig also pointed it out that there's
> an I2C dependency. (I cannot possibly do a full analysis of the
> dependencies of this code so i keep fixing up dependencies as they
> occur.)
>
> Ingo
>
> --------------------->
> Subject: media/video/sound build fix, TEA5761/TEA5767
> From: Ingo Molnar <mingo@elte.hu>
> Date: Wed Apr 30 12:44:02 CEST 2008
>
> x86.git randconfig testing found the following build error:
>
> drivers/built-in.o: In function `v4l2_i2c_drv_attach_legacy':
> tuner-core.c:(.text+0x1a829d): undefined reference to `v4l2_i2c_attach'
> drivers/built-in.o: In function `tuner_command':
> tuner-core.c:(.text+0x1a971c): undefined reference to `v4l_printk_ioctl'
>
> the reason is that the TEA5761/TEA5767 tuner code is dependent on
> (legacy?) V4L infrastructure like v4l2_i2c_attach, by virtue of
> drivers/media/video/tuner-core.c including media/v4l2-i2c-drv-legacy.h
> and ./sound/i2c/other/Makefile doing:
>
> snd-tea575x-tuner-objs := tea575x-tuner.o
>
> for now i solved this via adding a VIDEO_V4L2_COMMON dependency
> to MEDIA_TUNER - but i suspect there might be a better fix as well.
>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>

I guess this patch is also unnecessary if the reverse selection from
fm801-tea575x is replaced with depend by my patch. Then
VIDEO_V4L2_COMMON and I2C have to be turned on as the dependency of
VIDEO_V4L1.

thanks,

Takashi

> ---
> drivers/media/common/tuners/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux/drivers/media/common/tuners/Kconfig
> ===================================================================
> --- linux.orig/drivers/media/common/tuners/Kconfig
> +++ linux/drivers/media/common/tuners/Kconfig
> @@ -20,7 +20,7 @@ config MEDIA_ATTACH
> config MEDIA_TUNER
> tristate
> default DVB_CORE || VIDEO_DEV
> - depends on DVB_CORE || VIDEO_DEV
> + depends on (DVB_CORE || VIDEO_DEV) && VIDEO_V4L2_COMMON && I2C
> select MEDIA_TUNER_XC2028 if !MEDIA_TUNER_CUSTOMIZE
> select MEDIA_TUNER_XC5000 if !MEDIA_TUNER_CUSTOMIZE
> select MEDIA_TUNER_MT20XX if !MEDIA_TUNER_CUSTOMIZE
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>