public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-dvb-maintainer@linuxtv.org, video4linux-list@redhat.com,
	linux-kernel@vger.kernel.org
Subject: [patch, -git] drivers/media build fix for modular builds
Date: Wed, 30 Apr 2008 09:48:07 +0200	[thread overview]
Message-ID: <20080430074807.GA11224@elte.hu> (raw)
In-Reply-To: <20080429185009.716c3284@gaivota>


fix allmodconfig build bug introduced in latest -git by commit 
7c91f0624a9 ("V4L/DVB(7767): Move tuners to common/tuners"):

  LD      kernel/built-in.o
  LD      drivers/built-in.o
  ld: drivers/media/built-in.o: No such file: No such file or directory

which happens if all media drivers are modular:

  http://redhat.com/~mingo/misc/config-Wed_Apr_30_09_24_48_CEST_2008.bad

In that case there's no obj-y rule connecting all the built-in.o files and
the link tree breaks.

the fix is to add a guaranteed obj-y rule for the core vmlinux to build.
(which results in an empty object file if all media drivers are modular)

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 drivers/media/Makefile |    2 ++
 1 file changed, 2 insertions(+)

Index: linux/drivers/media/Makefile
===================================================================
--- linux.orig/drivers/media/Makefile
+++ linux/drivers/media/Makefile
@@ -2,6 +2,8 @@
 # Makefile for the kernel multimedia device drivers.
 #
 
+obj-y := common/
+
 obj-$(CONFIG_VIDEO_MEDIA) += common/
 
 # Since hybrid devices are here, should be compiled if DVB and/or V4L

  parent reply	other threads:[~2008-04-30  7:48 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-29 21:50 [GIT PATCHES] V4L/DVB updates and fixes for 2.6.26 Mauro Carvalho Chehab
2008-04-29 21:59 ` Linus Torvalds
2008-04-29 23:49 ` [v4l-dvb-maintainer] " Michael Krufky
2008-04-30  0:00   ` Mauro Carvalho Chehab
2008-04-30  7:48 ` Ingo Molnar [this message]
2008-04-30  7:52   ` [patch, -git] drivers/media build fix for modular builds David Miller
2008-04-30  8:13     ` Ingo Molnar
2008-04-30  8:27       ` Mike Galbraith
2008-04-30  8:42         ` Mike Galbraith
2008-04-30  8:56           ` Mike Galbraith
2008-04-30  9:20             ` Mike Galbraith
2008-04-30 11:40               ` Andrew Morton
2008-04-30 13:03                 ` Mike Galbraith
2008-04-30 14:39                   ` [v4l-dvb-maintainer] " Michael Krufky
2008-04-30 15:29                     ` Andrew Morton
2008-04-30 15:30                     ` Mike Galbraith
2008-04-30 15:34                     ` Andrew Morton
2008-04-30 15:39                       ` Michael Krufky
2008-04-30 16:01                         ` Mike Galbraith
2008-04-30 15:48                       ` Mauro Carvalho Chehab
2008-04-30 15:25                   ` Mauro Carvalho Chehab
2008-04-30 15:48                     ` Mike Galbraith
2008-04-30 16:12                       ` Mauro Carvalho Chehab
2008-04-30 16:31                         ` Mike Galbraith
2008-04-30 21:35                           ` Mauro Carvalho Chehab
2008-04-30 21:52                 ` [v4l-dvb-maintainer] " Trent Piepho
2008-04-30 22:38                   ` [v4l-dvb-maintainer] [patch, -git] drivers/media build fix fo r " mkrufky
2008-04-30  9:26             ` [patch, -git] drivers/media build fix for " Sam Ravnborg
2008-04-30  9:40               ` Mike Galbraith
2008-04-30 10:36                 ` Ingo Molnar
2008-04-30  9:25       ` Sam Ravnborg
2008-04-30  9:37         ` Ingo Molnar
2008-04-30  9:55           ` Sam Ravnborg
2008-04-30  8:02 ` [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates and fixes for 2.6.26 Patrick Boettcher
2008-04-30 19:03   ` Mauro Carvalho Chehab
  -- strict thread matches above, loose matches on Subject: below --
2008-05-07  3:49 [patch, -git] drivers/media build fix for modular builds Stephen Rothwell
2008-05-08 14:21 ` Thomas Backlund
2008-05-09  0:16   ` Gene Heskett
2008-05-09  0:18     ` David Miller
2008-05-09  5:57       ` Thomas Backlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080430074807.GA11224@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=linux-dvb-maintainer@linuxtv.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=torvalds@linux-foundation.org \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox