Re: [v4l-dvb-maintainer] [patch, -git] drivers/media build fix for modular builds

Andrew Morton
2008-04-30T15:31:46Z

On Wed, 30 Apr 2008 10:39:31 -0400 "Michael Krufky" <mkrufky@linuxtv.org> wrote:

> > [ 13.691175] DVB: Unable to find symbol tda9887_attach()
> > [ 13.698968] BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
> > [ 13.709509] IP: [<ffffffff80302934>] strlcpy+0x11/0x36

hm.

>
> Andrew's patch should have fixed the issue. His patch was correct, btw...

They always are ;) Watch this....

--- a/drivers/media/video/tuner-core.c~drivers-media-video-tuner-corec-tuner_probe-fix-error-check
+++ a/drivers/media/video/tuner-core.c
@@ -1181,7 +1181,7 @@ static int tuner_probe(struct i2c_client
case 0x60:
if (tuner_symbol_probe(tea5767_autodetection,
t->i2c->adapter, t->i2c->addr)
- != EINVAL) {
+ != -EINVAL) {
t->type = TUNER_TEA5767;
t->mode_mask = T_RADIO;
t->mode = T_STANDBY;
_