Re: [PATCH] x86: !x & y typo in mtrr code

Valdis.Kletnieks
2008-05-06T18:24:50Z

[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]

On Wed, 30 Apr 2008 08:35:34 PDT, Harvey Harrison said:
> On Wed, 2008-04-30 at 14:35 +0200, Ingo Molnar wrote:
> > We for one simply concentrate on the the things that we think makes it
> > more likely to find bugs. For example we build and boot x86.git with
> > many different configs before every pull request. In practice that
> > catches far more tester-critical bugs than Sparse - and we know that
> > simply from the fact because we use both methods and have a good
> > comparison of the results. We also work on automating Sparse checks in
> > the future but as i said it, it's not easy.
> >
>
> That's precisely why I've been sending all of the sparse cleanup patches
> lately, to try and get the output down to something more managable. You
> may want to upgrade your sparse to one that understands __cold though.

What release of sparse would that be? Fedora ships one tagged as 0.4.1-2.fc9,
but that says:

include/linux/kernel.h:135:52: error: attribute '__cold__': unknown attribute

But you go look at Documentation/sparse.txt and it points you to:

"You can get latest released versions from the Sparse homepage at
http://www.kernel.org/pub/linux/kernel/people/josh/sparse/ "

which says 0.4.1 is the latest released version. So is this a git-only feature?

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]