Re: [PATCH] x86: !x & y typo in mtrr code

Thomas Gleixner
2008-04-30T07:46:48Z

[-- Attachment #1: Type: TEXT/PLAIN, Size: 839 bytes --]

On Wed, 30 Apr 2008, Björn Steinbrink wrote:
> On 2008.04.29 23:04:35 +0200, Ingo Molnar wrote:
> >
> > * Al Viro <viro@ZenIV.linux.org.uk> wrote:
> >
> > > On Sat, Apr 26, 2008 at 09:00:17PM -0700, Harvey Harrison wrote:
> > > > As written, this can never be true.
> > >
> > > ... and introduced through x86.git, of all things... May I suggest
> > > that in addition to all-important whitespace hunting something that
> > > catches lowly real bugs would also be run over that tree? sparse
> > > *does* catch that...
> >
> > firstly, it _was_ caught via Sparse, ...
>
> But that is exactly Al's point. Had you run sparse over your tree
> _before_ it got pulled by Linus, that bug should have never made it into
> mainline.

sparse builds are on the way to the automated build framework
already. won't happen again.

Thanks,
tglx