From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758495AbYD3JiW (ORCPT ); Wed, 30 Apr 2008 05:38:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754137AbYD3JiN (ORCPT ); Wed, 30 Apr 2008 05:38:13 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:50110 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752786AbYD3JiN (ORCPT ); Wed, 30 Apr 2008 05:38:13 -0400 Date: Wed, 30 Apr 2008 11:37:28 +0200 From: Ingo Molnar To: Sam Ravnborg Cc: David Miller , mchehab@infradead.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux-dvb-maintainer@linuxtv.org, video4linux-list@redhat.com, linux-kernel@vger.kernel.org, sfr@canb.auug.org.au Subject: Re: [patch, -git] drivers/media build fix for modular builds Message-ID: <20080430093728.GA3568@elte.hu> References: <20080429185009.716c3284@gaivota> <20080430074807.GA11224@elte.hu> <20080430.005212.46815036.davem@davemloft.net> <20080430081345.GA16519@elte.hu> <20080430092500.GA31644@uranus.ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080430092500.GA31644@uranus.ravnborg.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Sam Ravnborg wrote: > drivers/media is special because it does not contain any files. Kbuild > will generate a built-in.o file only if there is a chance for a .o > file in the directory. > > When all media is modules kbuild does not know enough to say that a > built-in.o is needed in drivers/media/ and the workaround to do a > obj-y := common/ is the best way to do so. ok, good. Should be an exceedingly rare situation, we dont have _that_ many driver sub-trees. Can we take this as a: Acked-by: Sam Ravnborg ? :-) Ingo