Re: [patch, -git] drivers/media build fix for modular builds

Sam Ravnborg
2008-04-30T09:25:44Z

On Wed, Apr 30, 2008 at 10:56:24AM +0200, Mike Galbraith wrote:
>
> On Wed, 2008-04-30 at 10:42 +0200, Mike Galbraith wrote:
> > On Wed, 2008-04-30 at 10:27 +0200, Mike Galbraith wrote:
> > > On Wed, 2008-04-30 at 10:13 +0200, Ingo Molnar wrote:
> > > > * David Miller <davem@davemloft.net> wrote:
> > > >
> > > > > From: Ingo Molnar <mingo@elte.hu>
> > > > > Date: Wed, 30 Apr 2008 09:48:07 +0200
> > > > >
> > > > > >
> > > > > > fix allmodconfig build bug introduced in latest -git by commit
> > > > > > 7c91f0624a9 ("V4L/DVB(7767): Move tuners to common/tuners"):
> > > > > >
> > > > > > LD kernel/built-in.o
> > > > > > LD drivers/built-in.o
> > > > > > ld: drivers/media/built-in.o: No such file: No such file or directory
> > > > > >
> > > > > > which happens if all media drivers are modular:
> > > > >
> > > > > I was seeing this too, as I think was Stephen Rothwell.
> > > >
> > > > i think any build which has the media drivers only as modules will
> > > > trigger it, so it's rather widespread. My fix has held up fine for 10
> > > > randconfigs so far so it should do the trick.
> > >
> > > You also have to make clean after today's pull or...
> > >
> > > Kernel: arch/x86/boot/bzImage is ready (#3)
> > > ERROR: "tea5761_attach" [drivers/media/video/tuner.ko] undefined!
> > > ERROR: "tea5761_autodetection" [drivers/media/video/tuner.ko] undefined!
> > > ERROR: "microtune_attach" [drivers/media/video/tuner.ko] undefined!
> > > ERROR: "simple_tuner_attach" [drivers/media/video/tuner.ko] undefined!
> > > ERROR: "tda9887_attach" [drivers/media/video/tuner.ko] undefined!
> > > ERROR: "tea5767_autodetection" [drivers/media/video/tuner.ko] undefined!
> > > ERROR: "xc5000_attach" [drivers/media/video/tuner.ko] undefined!
> > > ERROR: "xc2028_attach" [drivers/media/video/tuner.ko] undefined!
> > > ERROR: "tda829x_probe" [drivers/media/video/tuner.ko] undefined!
> > > ERROR: "tda829x_attach" [drivers/media/video/tuner.ko] undefined!
> > > ERROR: "tea5767_attach" [drivers/media/video/tuner.ko] undefined!
> > > ERROR: "xc2028_attach" [drivers/media/video/saa7134/saa7134-dvb.ko] undefined!
> > > ERROR: "simple_tuner_attach" [drivers/media/video/saa7134/saa7134-dvb.ko] undefined!
> > > ERROR: "tda827x_attach" [drivers/media/video/saa7134/saa7134-dvb.ko] undefined!
> >
> > Hm, so I thought. Error is constant. Going back to .yesterday.
>
> Turning CONFIG_MEDIA_ATTACH on fixed it. I must have switched it somehow before.

So you did not have to do a make clean to make it build?
If make clean is needed then we have an issue in kbuild.

Sam