From: Ingo Molnar <mingo@elte.hu>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-dvb-maintainer@linuxtv.org, video4linux-list@redhat.com,
linux-kernel@vger.kernel.org, Mike Galbraith <efault@gmx.de>
Subject: [patch, -git] media/video/sound build fix, TEA5761/TEA5767
Date: Wed, 30 Apr 2008 13:01:15 +0200 [thread overview]
Message-ID: <20080430110115.GA5633@elte.hu> (raw)
x86.git randconfig testing found the following new build error in latest
-git:
drivers/built-in.o: In function `v4l2_i2c_drv_attach_legacy':
tuner-core.c:(.text+0x1a829d): undefined reference to `v4l2_i2c_attach'
drivers/built-in.o: In function `tuner_command':
tuner-core.c:(.text+0x1a971c): undefined reference to `v4l_printk_ioctl'
the reason appears to be that the TEA5761/TEA5767 tuner code is
dependent on (legacy?) V4L infrastructure like v4l2_i2c_attach, by
virtue of drivers/media/video/tuner-core.c including
media/v4l2-i2c-drv-legacy.h and ./sound/i2c/other/Makefile doing:
snd-tea575x-tuner-objs := tea575x-tuner.o
for now i solved this via adding a VIDEO_V4L2_COMMON dependency to
MEDIA_TUNER - which solves the build problem by excluding these drivers
- but i suspect there might be a better fix as well that does not
restrict the selectability of these drivers.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
drivers/media/common/tuners/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/drivers/media/common/tuners/Kconfig
===================================================================
--- linux.orig/drivers/media/common/tuners/Kconfig
+++ linux/drivers/media/common/tuners/Kconfig
@@ -20,7 +20,7 @@ config MEDIA_ATTACH
config MEDIA_TUNER
tristate
default DVB_CORE || VIDEO_DEV
- depends on DVB_CORE || VIDEO_DEV
+ depends on (DVB_CORE || VIDEO_DEV) && VIDEO_V4L2_COMMON
select MEDIA_TUNER_XC2028 if !MEDIA_TUNER_CUSTOMIZE
select MEDIA_TUNER_XC5000 if !MEDIA_TUNER_CUSTOMIZE
select MEDIA_TUNER_MT20XX if !MEDIA_TUNER_CUSTOMIZE
next reply other threads:[~2008-04-30 11:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 11:01 Ingo Molnar [this message]
2008-04-30 11:11 ` [patch, -git] media/video/sound build fix, TEA5761/TEA5767 Takashi Iwai
2008-04-30 11:15 ` Ingo Molnar
2008-04-30 11:18 ` Ingo Molnar
2008-04-30 11:21 ` Ingo Molnar
2008-04-30 11:58 ` Takashi Iwai
2008-04-30 12:05 ` Ingo Molnar
2008-04-30 12:36 ` [v4l-dvb-maintainer] " Michael Krufky
2008-04-30 12:01 ` Takashi Iwai
2008-04-30 11:17 ` David Miller
2008-04-30 11:29 ` Sam Ravnborg
2008-04-30 12:09 ` Takashi Iwai
2008-04-30 12:18 ` Ingo Molnar
2008-05-02 15:06 ` Sam Ravnborg
2008-05-05 20:34 ` Mauro Carvalho Chehab
2008-04-30 11:54 ` Takashi Iwai
2008-04-30 11:13 ` Ingo Molnar
2008-04-30 12:04 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080430110115.GA5633@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=efault@gmx.de \
--cc=linux-dvb-maintainer@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox