From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761493AbYD3LO1 (ORCPT ); Wed, 30 Apr 2008 07:14:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756793AbYD3LOS (ORCPT ); Wed, 30 Apr 2008 07:14:18 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:59442 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755586AbYD3LOS (ORCPT ); Wed, 30 Apr 2008 07:14:18 -0400 Date: Wed, 30 Apr 2008 13:13:37 +0200 From: Ingo Molnar To: Mauro Carvalho Chehab Cc: Andrew Morton , linux-dvb-maintainer@linuxtv.org, video4linux-list@redhat.com, linux-kernel@vger.kernel.org, Mike Galbraith Subject: Re: [patch, -git] media/video/sound build fix, TEA5761/TEA5767 Message-ID: <20080430111337.GA9170@elte.hu> References: <20080430110115.GA5633@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080430110115.GA5633@elte.hu> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Ingo Molnar wrote: > x86.git randconfig testing found the following new build error in > latest -git: updated fix below - another randconfig also pointed it out that there's an I2C dependency. (I cannot possibly do a full analysis of the dependencies of this code so i keep fixing up dependencies as they occur.) Ingo ---------------------> Subject: media/video/sound build fix, TEA5761/TEA5767 From: Ingo Molnar Date: Wed Apr 30 12:44:02 CEST 2008 x86.git randconfig testing found the following build error: drivers/built-in.o: In function `v4l2_i2c_drv_attach_legacy': tuner-core.c:(.text+0x1a829d): undefined reference to `v4l2_i2c_attach' drivers/built-in.o: In function `tuner_command': tuner-core.c:(.text+0x1a971c): undefined reference to `v4l_printk_ioctl' the reason is that the TEA5761/TEA5767 tuner code is dependent on (legacy?) V4L infrastructure like v4l2_i2c_attach, by virtue of drivers/media/video/tuner-core.c including media/v4l2-i2c-drv-legacy.h and ./sound/i2c/other/Makefile doing: snd-tea575x-tuner-objs := tea575x-tuner.o for now i solved this via adding a VIDEO_V4L2_COMMON dependency to MEDIA_TUNER - but i suspect there might be a better fix as well. Signed-off-by: Ingo Molnar --- drivers/media/common/tuners/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/drivers/media/common/tuners/Kconfig =================================================================== --- linux.orig/drivers/media/common/tuners/Kconfig +++ linux/drivers/media/common/tuners/Kconfig @@ -20,7 +20,7 @@ config MEDIA_ATTACH config MEDIA_TUNER tristate default DVB_CORE || VIDEO_DEV - depends on DVB_CORE || VIDEO_DEV + depends on (DVB_CORE || VIDEO_DEV) && VIDEO_V4L2_COMMON && I2C select MEDIA_TUNER_XC2028 if !MEDIA_TUNER_CUSTOMIZE select MEDIA_TUNER_XC5000 if !MEDIA_TUNER_CUSTOMIZE select MEDIA_TUNER_MT20XX if !MEDIA_TUNER_CUSTOMIZE