From: David Brownell <david-b@pacbell.net>
To: spi-devel-general@lists.sourceforge.net
Cc: Kumar Gala <galak@kernel.crashing.org>,
Roel Kluin <12o3l@tiscali.nl>,
"linuxppc-dev@ozlabs.org list" <linuxppc-dev@ozlabs.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [spi-devel-general] [PATCH] spi_mpc83xx: test below 0 on unsigned irq in mpc83xx_spi_probe()
Date: Wed, 30 Apr 2008 15:12:10 -0700 [thread overview]
Message-ID: <200804301512.11317.david-b@pacbell.net> (raw)
In-Reply-To: <7C711FFF-E1C5-4286-93A8-382055C6760C@kernel.crashing.org>
On Wednesday 23 April 2008, Kumar Gala wrote:
>
> On Apr 23, 2008, at 3:19 PM, Roel Kluin wrote:
> > mpc83xx_spi->irq is unsigned, so the test fails
> >
> > Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Any reason to not just make mpc83xx_spi->irq be "int",
following normal practice everywhere? If not, I'll
roll that into the patch from Joakim Tjernlund...
- Dave
next prev parent reply other threads:[~2008-04-30 22:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 20:19 [PATCH] spi_mpc83xx: test below 0 on unsigned irq in mpc83xx_spi_probe() Roel Kluin
2008-04-23 20:39 ` Kumar Gala
2008-04-30 22:12 ` David Brownell [this message]
2008-04-23 20:55 ` [PATCH 2/2] xilinx_spi: test below 0 on unsigned irq in xilinx_spi_probe() Roel Kluin
2008-04-24 7:35 ` [PATCH 2/2 v2] " Roel Kluin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804301512.11317.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=12o3l@tiscali.nl \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox