From: Ingo Molnar <mingo@elte.hu>
To: Hugh Dickins <hugh@veritas.com>
Cc: "J.A. Magallón" <jamagallon@ono.com>,
"Glauber Costa" <gcosta@redhat.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: Problems with -git14
Date: Wed, 30 Apr 2008 20:13:32 +0200 [thread overview]
Message-ID: <20080430181332.GC31726@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.64.0804301516580.30549@blonde.site>
* Hugh Dickins <hugh@veritas.com> wrote:
> static inline int cpu_present_to_apicid(int mps_cpu)
> {
> -#ifdef CONFIG_X86_64
> - if (cpu_present(mps_cpu))
> + if (mps_cpu < NR_CPUS && cpu_present(mps_cpu))
> return (int)per_cpu(x86_bios_cpu_apicid, mps_cpu);
> -#else
> - if (mps_cpu < get_physical_broadcast())
> - return mps_cpu;
> -#endif
> else
> return BAD_APICID;
> }
applied. Thanks Hugh for the detective work! I love fixes that only
remove code ;-)
Ingo
next prev parent reply other threads:[~2008-04-30 18:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 23:56 Problems with -git14 J.A. Magallón
2008-04-30 15:17 ` Hugh Dickins
2008-04-29 17:22 ` Arjan van de Ven
2008-04-30 15:54 ` Glauber Costa
2008-05-05 7:13 ` Andrey Panin
2008-05-05 7:49 ` Thomas Gleixner
2008-04-30 18:13 ` Ingo Molnar [this message]
2008-04-30 18:27 ` Ingo Molnar
2008-04-30 19:40 ` J.A. Magallón
2008-05-01 12:04 ` Hugh Dickins
2008-05-01 0:50 ` J.A. Magallón
2008-05-01 12:11 ` Hugh Dickins
2008-05-02 1:41 ` Nick Piggin
2008-05-06 19:13 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080430181332.GC31726@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=gcosta@redhat.com \
--cc=hugh@veritas.com \
--cc=jamagallon@ono.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox