From: Sam Ravnborg <sam@ravnborg.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [patch] inlining: do not allow gcc below version 4 to optimize inlining
Date: Wed, 30 Apr 2008 21:58:10 +0200 [thread overview]
Message-ID: <20080430195810.GA4660@uranus.ravnborg.org> (raw)
In-Reply-To: <20080430190307.GC29330@cs181133002.pp.htv.fi>
On Wed, Apr 30, 2008 at 10:03:07PM +0300, Adrian Bunk wrote:
> > /*
> > - * Force always-inline if the user requests it so via the .config:
> > + * Force always-inline if the user requests it so via the .config,
> > + * or if gcc is too old:
> > */
> > #if !defined(CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING) || \
> > - !defined(CONFIG_OPTIMIZE_INLINING) && (__GNUC__ >= 4)
>
> One moment.
>
> Let me try to understand what we currently have in the tree.
>
> This *always* enables the so called "optimized inlining" for the older
> compilers we did *not* wanted to have this for.
>
> Even with CONFIG_OPTIMIZE_INLINING=n .
>
> How was this reviewed and tested?
I for one reviewed this.
No I did not catch the obvious bug and
feel free to flame me for that.
Sam
next prev parent reply other threads:[~2008-04-30 19:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 22:15 [patch] inlining: do not allow gcc below version 4 to optimize inlining Ingo Molnar
2008-04-30 19:03 ` Adrian Bunk
2008-04-30 19:58 ` Sam Ravnborg [this message]
2008-04-30 20:38 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080430195810.GA4660@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=bunk@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox