public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Jason Baron <jbaron@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [patch 0/3] dynamic_printk: new feature
Date: Wed, 30 Apr 2008 20:44:49 -0700	[thread overview]
Message-ID: <20080501034449.GD6339@kroah.com> (raw)
In-Reply-To: <20080430210147.GA5616@redhat.com>

First off, I agree with Andrew, this is a very welcome thing to do.  If
there's anything I can do to help this out, please let me know.

On Wed, Apr 30, 2008 at 05:01:50PM -0400, Jason Baron wrote:
> On Wed, Apr 30, 2008 at 12:45:06PM -0700, Andrew Morton wrote:
> > We're now in the situation where numerous different subsystems have
> > implemented private mechnisms for tuning their printk verbosity levels.
> > 
> > Have you taken a look across the tree with a view to converting some of
> > them?  If so, how sizeable/messy/feasible would that task be?
> > 
> > 
> 
> i really only focused on pr_debug()/dev_dbg(), with an eye towards
> widening the scope as we go...but I agree that it would be nice to
> understand the scope for the start...i find ~5000 call sites to
> dprintk(), which would be ideal candidates for this type of
> infrastructure.

That's a good first start :)

Lots of the existing printk() type wrappers can also use the dev_*
versions as well (like the ALSA ones for example.)  So it might be
easier to focus on the existing users of these two functions, and then
work to convert the other different variants over to the dev_printk ones
where possible and d_printk where not (you don't always have a struct
device to use at the moment, which is required by dev_printk)

If you want to start with the USB core and drivers, I'll be glad to help
ensure those patches go in as well.

thanks,

greg k-h

  reply	other threads:[~2008-05-01  3:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-29 18:39 [patch 0/3] dynamic_printk: new feature Jason Baron
2008-04-30 19:45 ` Andrew Morton
2008-04-30 20:54   ` Joe Perches
2008-04-30 21:01   ` Jason Baron
2008-05-01  3:44     ` Greg KH [this message]
2008-05-01  0:23   ` Nick Andrew

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080501034449.GD6339@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@linux-foundation.org \
    --cc=jbaron@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox