Re: [PATCH] fix rebuild of wakeup.bin

Sam Ravnborg
2008-05-04T07:21:20Z

On Sat, May 03, 2008 at 09:41:49PM +0200, Ingo Molnar wrote:
>
> * Sam Ravnborg <sam@ravnborg.org> wrote:
>
> > On Sat, May 03, 2008 at 08:06:12PM +0200, Ingo Molnar wrote:
> > >
> > > * Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > >
> > > > > Add wakeup.lds to list af targets to avoid rebuilding wakeup.bin -
> > > > > from Roland McGrath.
> > > >
> > > > Thanks for fixing this!
> > > >
> > > > Ingo, please merge.
> > >
> > > applied - thanks all!
> >
> > Just a note - I do not think this solves the problem Daniel has
> > reported with respect to first build of -next. I am awaiting more data
> > before I can analyse it further.
>
> yeah, i suspected that - that appears to be a race of some sort, i.e. a
> missing dependency coupled with parallelizable rules, not an over-eager
> dependency as fixed by this patch, right?

In the end it should be fixed by this patch.
It turned out to be a user rights issue where I assume
wakeup-lds were owned by root because we created it
despite have a fully build kernel.

This also explains why we did not see more reports on the subject.

So please push this fix towards linus soonish.

Thanks,
Sam