From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761648AbYEAPbV (ORCPT ); Thu, 1 May 2008 11:31:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753542AbYEAPbJ (ORCPT ); Thu, 1 May 2008 11:31:09 -0400 Received: from verein.lst.de ([213.95.11.210]:36279 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752631AbYEAPbH (ORCPT ); Thu, 1 May 2008 11:31:07 -0400 Date: Thu, 1 May 2008 17:30:32 +0200 From: Christoph Hellwig To: "Theodore Ts'o" Cc: Christoph Hellwig , torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, olaf@aepfle.de Subject: Re: [PATCH, RFC] ext3: move headers out of include/linux Message-ID: <20080501153032.GA10754@lst.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.28i X-Spam-Score: -0.001 () BAYES_44 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 01, 2008 at 10:40:37AM -0400, Theodore Ts'o wrote: > Secondly, Christoph, was there a reason why you didn't unpublish > ext2_fs.h when you unpublished ext3_fs.h? Are there a significant > number of userspace prorams using it? I don't care, because e2fsprogs > doesn't use it, and as far as I'm concerned I'd much rather encourage > people to use ext2fs/ext2_fs.h from e2fsprogs instead. And this would > allow us to do a similar patch for fs/ext2; but assume you had found > some significant number of applications that would break if we > unexported and moved linux/ext2_fs.h? ext2_fs.h has been there for much longer, and unlike ext3_fs.h it actually is useable by userpsace. Of course everyone should be using the headers from e2fsprogs by now, but I'm not sure if that's really the case. In past cases like that Olaf did greps over the whole OpenSuSE tree, so maybe he could do it for this aswell?