From: Michael Buesch <mb@bu3sch.de>
To: Jesse Barnes <jbarnes@virtuousgeek.org>,
John Linville <linville@tuxdriver.com>
Cc: Andi Kleen <andi@firstfloor.org>,
David Miller <davem@davemloft.net>,
Alan Cox <alan@lxorguk.ukuu.org.uk>, Ingo Molnar <mingo@elte.hu>,
bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org,
"linux-kernel" <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/3] ssb: Add weak DMA-mask API
Date: Thu, 1 May 2008 16:41:27 +0200 [thread overview]
Message-ID: <200805011641.28135.mb@bu3sch.de> (raw)
In-Reply-To: <200805011638.15910.mb@bu3sch.de>
This adds a "weak" variant of ssb_dma_set_mask().
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Index: linux-2.6/drivers/ssb/main.c
===================================================================
--- linux-2.6.orig/drivers/ssb/main.c 2008-05-01 13:19:53.000000000 +0200
+++ linux-2.6/drivers/ssb/main.c 2008-05-01 13:47:29.000000000 +0200
@@ -1165,6 +1165,12 @@ u32 ssb_dma_translation(struct ssb_devic
}
EXPORT_SYMBOL(ssb_dma_translation);
+static void do_set_dma_mask(struct device *dma_dev, u64 mask)
+{
+ dma_dev->coherent_dma_mask = mask;
+ dma_dev->dma_mask = &dma_dev->coherent_dma_mask;
+}
+
int ssb_dma_set_mask(struct ssb_device *ssb_dev, u64 mask)
{
struct device *dma_dev = ssb_dev->dma_dev;
@@ -1173,13 +1179,26 @@ int ssb_dma_set_mask(struct ssb_device *
if (ssb_dev->bus->bustype == SSB_BUSTYPE_PCI)
return dma_set_mask(dma_dev, mask);
#endif
- dma_dev->coherent_dma_mask = mask;
- dma_dev->dma_mask = &dma_dev->coherent_dma_mask;
+ do_set_dma_mask(dma_dev, mask);
return 0;
}
EXPORT_SYMBOL(ssb_dma_set_mask);
+int ssb_dma_set_mask_weak(struct ssb_device *ssb_dev, u64 *mask)
+{
+ struct device *dma_dev = ssb_dev->dma_dev;
+
+#ifdef CONFIG_SSB_PCIHOST
+ if (ssb_dev->bus->bustype == SSB_BUSTYPE_PCI)
+ return dma_set_mask_weak(dma_dev, mask);
+#endif
+ do_set_dma_mask(dma_dev, *mask);
+
+ return 0;
+}
+EXPORT_SYMBOL(ssb_dma_set_mask_weak);
+
int ssb_bus_may_powerdown(struct ssb_bus *bus)
{
struct ssb_chipcommon *cc;
Index: linux-2.6/include/linux/ssb/ssb.h
===================================================================
--- linux-2.6.orig/include/linux/ssb/ssb.h 2008-05-01 13:19:59.000000000 +0200
+++ linux-2.6/include/linux/ssb/ssb.h 2008-05-01 13:43:17.000000000 +0200
@@ -406,6 +406,7 @@ extern u32 ssb_dma_translation(struct ss
#define SSB_DMA_TRANSLATION_SHIFT 30
extern int ssb_dma_set_mask(struct ssb_device *ssb_dev, u64 mask);
+extern int ssb_dma_set_mask_weak(struct ssb_device *ssb_dev, u64 *mask);
#ifdef CONFIG_SSB_PCIHOST
--
Greetings Michael.
next prev parent reply other threads:[~2008-05-01 14:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-01 14:38 [PATCH 0/3] Add API for weak DMA masks Michael Buesch
2008-05-01 9:00 ` Arjan van de Ven
2008-05-01 14:40 ` [PATCH 1/3] Add dma_set_mask_weak() API Michael Buesch
2008-05-01 16:20 ` Alan Cox
2008-05-01 17:11 ` Michael Buesch
2008-05-01 14:41 ` Michael Buesch [this message]
2008-05-01 14:43 ` [PATCH 3/3] b43: Use the new weak DMA-mask API Michael Buesch
2008-05-01 15:36 ` [PATCH 0/3] Add API for weak DMA masks Christoph Hellwig
2008-05-01 15:42 ` Michael Buesch
2008-05-01 15:43 ` Christoph Hellwig
2008-05-01 15:47 ` Michael Buesch
2008-05-01 15:58 ` Christoph Hellwig
2008-05-01 16:07 ` Michael Buesch
2008-05-01 16:30 ` Jesse Barnes
2008-05-01 17:16 ` Michael Buesch
2008-05-01 17:22 ` Jesse Barnes
2008-05-01 17:25 ` Michael Buesch
2008-05-01 17:27 ` Jesse Barnes
2008-05-01 17:33 ` Michael Buesch
2008-05-01 16:29 ` Alan Cox
2008-05-01 21:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805011641.28135.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=davem@davemloft.net \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox