From: Andrew Morton <akpm@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
peterz@infradead.org, hch@infradead.org, adobriyan@gmail.com,
bunk@kernel.org
Subject: Re: [PATCH] add typecheck on irqsave and friends for correct flags
Date: Thu, 1 May 2008 17:28:10 -0700 [thread overview]
Message-ID: <20080501172810.fa39dad6.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0805011946290.12785@gandalf.stny.rr.com>
On Thu, 1 May 2008 19:51:18 -0400 (EDT)
Steven Rostedt <rostedt@goodmis.org> wrote:
> There has been several areas in the kernel where an int has been used
> for flags in local_irq_save and friends instead of a long. This can
> cause some hard to debug problems on some architectures.
>
> This patch adds a typecheck inside the irqsave and restore functions
> to flag these cases.
hm, not exactly a thing of beauty, but it could have been worse.
If we had implemeted these things properly, as
unsigned long spin_lock_irqsave(spinlock_t *lock);
then we wouldn't be able to do this at all.
Oh well, thanks, I'll toss it in there. Maybe this should go into
git-sched (aka git-omnibus)?
next prev parent reply other threads:[~2008-05-02 0:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-01 23:51 [PATCH] add typecheck on irqsave and friends for correct flags Steven Rostedt
2008-05-02 0:28 ` Andrew Morton [this message]
2008-05-02 1:16 ` Steven Rostedt
2008-05-02 1:49 ` Andrew Morton
2008-05-02 1:57 ` Steven Rostedt
2008-05-02 8:37 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080501172810.fa39dad6.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=bunk@kernel.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox