public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alistair John Strachan <alistair@devzero.co.uk>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Chris Knadle <Chris.Knadle@coredump.us>,
	Andrew Morton <akpm@linux-foundation.org>,
	Adrian Bunk <bunk@kernel.org>,
	venkatesh.pallipadi@intel.com, davem@davemloft.net,
	trini@kernel.crashing.org, mingo@elte.hu, tglx@linutronix.de,
	hpa@zytor.com, linux-kernel@vger.kernel.org,
	suresh.b.siddha@intel.com,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: huge gcc 4.1.{0,1} __weak problem
Date: Fri, 2 May 2008 12:48:55 +0100	[thread overview]
Message-ID: <200805021248.56797.alistair@devzero.co.uk> (raw)
In-Reply-To: <20080502104348.GC20741@uranus.ravnborg.org>

On Friday 02 May 2008 11:43:48 Sam Ravnborg wrote:
[snip]
> > > > It's __GNUC_PATCHLEVEL__, I believe.
> > > >
> > > > So yes, we can distinguish 4.1.2 (good, and very common) from
> > > > 4.1.{0,1} (bad, and rather uncommon).
> > > > And yes, considering that 4.1.1 (and even more so 4.1.0) should be
> > > > rare to begin with, I think it's better to just not support it.
> > > >
> > > >			Linus
> > >
> > >    Unfortunately Debian Stable (i.e. Etch), which is relatively popular
> > > for server use, is still using 4.1.1  :-(  (The current gcc package is
> > > gcc-4.1.1-21)
> > >
> > >    I have not looked to see if Debian Stable's gcc-4.1.1-21 has been
> > > patched for the currently discussed __weak bug.
> >
> > I checked and it has been patched in 4.1.1-21. This would make checking
> > for 4.1.1 via __GNUC_PATCHLEVEL__ potentially invalid, as patched distro
> > compilers may (and in this case do) have this fixed.
>
> Is it possible to cook up a small sample file we could build as part
> of the kernel build. If it fails => error out.
> If someone comes up with the code I shall try to integrate it
> in the build system.

The GCC PR has a test case for this regression which might be usable.

http://gcc.gnu.org/viewcvs/branches/gcc-4_1-branch/gcc/testsuite/gcc.dg/tree-ssa/pr27781.c?view=markup&pathrev=114852

-- 
Cheers,
Alistair.

137/1 Warrender Park Road, Edinburgh, UK.

  reply	other threads:[~2008-05-02 12:28 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-01 23:55 huge gcc 4.1.{0,1} __weak problem Chris Knadle
2008-05-02  9:19 ` Miquel van Smoorenburg
2008-05-02  9:55 ` Alistair John Strachan
2008-05-02 10:43   ` Sam Ravnborg
2008-05-02 11:48     ` Alistair John Strachan [this message]
2008-05-02 13:57       ` Sam Ravnborg
2008-05-02 14:11         ` Jakub Jelinek
2008-05-02 15:26           ` Alistair John Strachan
2008-05-02 14:57         ` Jeremy Fitzhardinge
2008-05-02 12:40   ` Sven-Haegar Koch
  -- strict thread matches above, loose matches on Subject: below --
2008-04-30  1:31 [PATCH] /dev/mem gcc weak function workaround Venki Pallipadi
2008-04-30  4:28 ` David Miller
2008-04-30 12:49   ` Pallipadi, Venkatesh
2008-05-01 21:56     ` huge gcc 4.1.{0,1} __weak problem Adrian Bunk
2008-05-01 22:20       ` Andrew Morton
2008-05-01 22:27         ` Linus Torvalds
2008-05-01 22:33           ` Andrew Morton
2008-05-01 23:24             ` Tom Rini
2008-05-01 23:59               ` Andrew Morton
2008-05-02  0:21                 ` Justin Mattock
2008-05-02  7:18                 ` Vegard Nossum
2008-05-02 13:43                   ` Theodore Tso
2008-05-02  8:10                 ` Adrian Bunk
2008-05-02  9:09                 ` Andi Kleen
2008-05-01 22:35           ` Venki Pallipadi
2008-05-01 22:42             ` Andrew Morton
2008-05-01 22:49               ` Jakub Jelinek
2008-05-01 23:21               ` Tom Rini
2008-05-01 23:30                 ` Venki Pallipadi
2008-05-02  0:34                   ` Linus Torvalds
2008-05-02  0:39                     ` Suresh Siddha
2008-05-02 21:11                       ` Jeremy Fitzhardinge
2008-05-02 22:02                         ` David Miller
2008-05-01 23:23             ` Tom Rini
2008-05-01 22:51           ` David Miller
2008-05-02 21:09       ` Jeremy Fitzhardinge
2008-05-02 21:19         ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805021248.56797.alistair@devzero.co.uk \
    --to=alistair@devzero.co.uk \
    --cc=Chris.Knadle@coredump.us \
    --cc=akpm@linux-foundation.org \
    --cc=bunk@kernel.org \
    --cc=davem@davemloft.net \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sam@ravnborg.org \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=trini@kernel.crashing.org \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox