From: Dave Jones <davej@codemonkey.org.uk>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Arjan van de Ven <arjan@infradead.org>,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Extend list debugging to cover hlists
Date: Fri, 2 May 2008 15:05:01 -0400 [thread overview]
Message-ID: <20080502190501.GA31017@codemonkey.org.uk> (raw)
In-Reply-To: <20080502184922.GM14976@parisc-linux.org>
On Fri, May 02, 2008 at 12:49:22PM -0600, Matthew Wilcox wrote:
> On Thu, May 01, 2008 at 01:32:09PM -0700, Arjan van de Ven wrote:
> > I like the concept of the patch; however...
> > BUG() is a tad on the rude side... how about WARN_ON(1) ?
>
> I'm just copying the conventions of the code above. If those should be
> WARN_ON(1) then that should be a followup patch.
No objections from me either way. I chose to BUG originally because
the bug I was chasing was corrupting memory in such a way that we'd
die horribly shortly afterwards anyway.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2008-05-02 19:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 18:27 [PATCH] Extend list debugging to cover hlists Matthew Wilcox
2008-05-01 20:32 ` Arjan van de Ven
2008-05-02 18:49 ` Matthew Wilcox
2008-05-02 19:05 ` Dave Jones [this message]
2008-05-20 3:24 ` [PATCH] Make Dave Jones
2008-05-20 14:14 ` Arjan van de Ven
2008-05-20 14:27 ` Dave Jones
2008-05-20 14:54 ` Linus Torvalds
2008-05-20 15:20 ` Dave Jones
2008-05-20 16:15 ` Arjan van de Ven
2008-05-20 15:00 ` Alexey Dobriyan
2008-05-20 15:12 ` Linus Torvalds
2008-05-20 15:22 ` Dave Jones
2008-05-20 21:52 ` [PATCH] Make (LIST_DEBUG WARN not BUG) Alexey Dobriyan
2008-05-02 23:14 ` [PATCH] Extend list debugging to cover hlists Andrew Morton
2008-05-02 23:17 ` Matthew Wilcox
2008-05-02 23:39 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080502190501.GA31017@codemonkey.org.uk \
--to=davej@codemonkey.org.uk \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox