From: Andrew Morton <akpm@linux-foundation.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: "Jörn Engel" <joern@logfs.org>,
linux-kernel@vger.kernel.org, joern@lazybastard.org,
"Andy Whitcroft" <apw@shadowen.org>
Subject: Re: [PATCH] fix checkstack.pl arch detection
Date: Fri, 2 May 2008 19:31:28 -0700 [thread overview]
Message-ID: <20080502193128.5e1de100.akpm@linux-foundation.org> (raw)
In-Reply-To: <481BCC00.1030508@redhat.com>
On Fri, 02 May 2008 21:20:48 -0500 Eric Sandeen <sandeen@redhat.com> wrote:
> Andrew Morton wrote:
> > On Sat, 3 May 2008 00:37:03 +0200
> > J__rn Engel <joern@logfs.org> wrote:
> >
> >> On Fri, 2 May 2008 12:20:53 -0500, Eric Sandeen wrote:
> >>> uname -m was leaving a newline in $arch, and not passing the tests.
> >>>
> >>> Also, printing the unknown arch on failure is probably helpful.
> >>>
> >>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> >> Reviewed-By: Joern Engel <joern@logfs.org>
> >>
> >
> > please cc apw on checkpatch changes.
> >
> > This patch needs some help to merge against the forthcoming
> > checkpatch-0.19. I sent your patches apw-wards.
> >
>
> Um, checkpatch or checkstack? :)
>
bah.
hm, I wonder why one of them got a reject. `patch -l' was needed. Mailer
munchies, perhaps?
Please check that what I applied is still correct.
next prev parent reply other threads:[~2008-05-03 2:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 17:20 [PATCH] fix checkstack.pl arch detection Eric Sandeen
2008-05-02 22:37 ` Jörn Engel
2008-05-02 23:44 ` Andrew Morton
2008-05-03 2:20 ` Eric Sandeen
2008-05-03 2:31 ` Andrew Morton [this message]
2008-05-03 2:40 ` Eric Sandeen
2008-05-03 2:51 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080502193128.5e1de100.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=joern@lazybastard.org \
--cc=joern@logfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox