From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763048AbYECKHo (ORCPT ); Sat, 3 May 2008 06:07:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755256AbYECKHh (ORCPT ); Sat, 3 May 2008 06:07:37 -0400 Received: from pasmtpa.tele.dk ([80.160.77.114]:46843 "EHLO pasmtpA.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755189AbYECKHg (ORCPT ); Sat, 3 May 2008 06:07:36 -0400 Date: Sat, 3 May 2008 12:08:10 +0200 From: Sam Ravnborg To: Thomas Gleixner Cc: Ingo Molnar , Adrian Bunk , "H. Peter Anvin" , Hiroshi Shimamoto , linux-kernel@vger.kernel.org Subject: Re: x86 git acpi issue? Message-ID: <20080503100810.GA15645@uranus.ravnborg.org> References: <481BAC6F.5090509@ct.jp.nec.com> <481BACEC.8080902@zytor.com> <20080503071332.GF5838@cs181133002.pp.htv.fi> <20080503094551.GA10805@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 03, 2008 at 12:02:37PM +0200, Thomas Gleixner wrote: > On Sat, 3 May 2008, Ingo Molnar wrote: > > > Right. This Makefile is a nasty trap. I looked into it and the fix for > > > now is below. Long term this Makefile trickery needs to be cleaned up > > > to avoid trapping into this again. > > > > Thanks Thomas, i messed up that commit - i should have known that the > > NUMAQ build fix looked _too_ easy ;-) > > Also the move of > pci-$(CONFIG_ACPI) += acpi.o > is what broke things. > > There is a nasty init function ordering problem as well between > > pci-$(CONFIG_ACPI) += acpi.o > pci-y += legacy.o irq.o > > Sigh. This is the kind of stuff that has prevented me from unifying the two Makefiles. But if no-one beats me I will give it a shot soon. It will be a microsteps because we will likeky hit such issues. Sam