public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Adrian Bunk <bunk@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
	Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>,
	linux-kernel@vger.kernel.org
Subject: Re: x86 git acpi issue?
Date: Sat, 3 May 2008 13:10:04 +0200	[thread overview]
Message-ID: <20080503111004.GC22543@elte.hu> (raw)
In-Reply-To: <20080503100810.GA15645@uranus.ravnborg.org>


* Sam Ravnborg <sam@ravnborg.org> wrote:

> On Sat, May 03, 2008 at 12:02:37PM +0200, Thomas Gleixner wrote:
> > On Sat, 3 May 2008, Ingo Molnar wrote:
> > > > Right. This Makefile is a nasty trap. I looked into it and the fix for 
> > > > now is below. Long term this Makefile trickery needs to be cleaned up 
> > > > to avoid trapping into this again.
> > > 
> > > Thanks Thomas, i messed up that commit - i should have known that the 
> > > NUMAQ build fix looked _too_ easy ;-)
> > 
> > Also the move of 
> > pci-$(CONFIG_ACPI)             += acpi.o
> > is what broke things.
> > 
> > There is a nasty init function ordering problem as well between
> > 
> > pci-$(CONFIG_ACPI)             += acpi.o
> > pci-y                          += legacy.o irq.o
> > 
> > Sigh.
> 
> This is the kind of stuff that has prevented me from unifying the two 
> Makefiles. But if no-one beats me I will give it a shot soon. It will 
> be a microsteps because we will likeky hit such issues.

yeah, it needs to be micro-steps (nice word! :) as this stuff is very 
subtle.

	Ingo

      reply	other threads:[~2008-05-03 11:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-03  0:06 x86 git acpi issue? Hiroshi Shimamoto
2008-05-03  0:08 ` H. Peter Anvin
2008-05-03  0:30   ` Hiroshi Shimamoto
2008-05-03  7:13   ` Adrian Bunk
2008-05-03  9:27     ` Thomas Gleixner
2008-05-03  9:45       ` Ingo Molnar
2008-05-03 10:02         ` Thomas Gleixner
2008-05-03 10:08           ` Sam Ravnborg
2008-05-03 11:10             ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080503111004.GC22543@elte.hu \
    --to=mingo@elte.hu \
    --cc=bunk@kernel.org \
    --cc=h-shimamoto@ct.jp.nec.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox