From: Ingo Molnar <mingo@elte.hu>
To: jamal <hadi@cyberus.ca>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Suresh Siddha <suresh.b.siddha@intel.com>,
Arjan van de Ven <arjan@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Jan Beulich <jbeulich@novell.com>
Subject: Re: i387/FPU init issues...
Date: Sat, 3 May 2008 19:34:02 +0200 [thread overview]
Message-ID: <20080503173402.GA5292@elte.hu> (raw)
In-Reply-To: <1209834123.6972.48.camel@localhost>
* jamal <hadi@cyberus.ca> wrote:
> > we have:
> > #define P6_NOP3 ".byte 0x0f,0x1f,0x00\n"
>
> Dang - I feel i should have saved myself all that git bisecting
> and just posted the oops ;->
your bisection was still very useful - it pinpointed the NOPs - the
assembly code around the NOP changed so a different length NOP was
patched in => which did not work on your CPU. So thanks for that! The
fix is already in x86.git (we'll update the commit log).
> > So the alternatives code applies the wrong nop padding for your CPU.
> > This was probably introduced with commit
> > 32c464f5d9701db45bc1673288594e664065388e.
> >
> > Jan, are you sure that P3 knows the P6 NOPs ? AFAICT its P4, but I
> > have to dig up the manuals.
> >
> > Jamal, does the following patch solve your problem ?
>
> Indeed it does - thanks.
great. So this NOP is indeed not generally known to all "P6 and later"
CPUs. (the PII)
Ingo
next prev parent reply other threads:[~2008-05-03 17:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-03 10:32 i387/FPU init issues jamal
2008-05-03 10:57 ` James Courtier-Dutton
2008-05-03 13:53 ` jamal
2008-05-03 15:31 ` Thomas Gleixner
2008-05-03 17:02 ` jamal
2008-05-03 17:34 ` Ingo Molnar [this message]
2008-05-03 17:39 ` Thomas Gleixner
2008-05-04 21:31 ` Jan Engelhardt
2008-05-04 21:37 ` H. Peter Anvin
2008-05-05 13:00 ` Lennart Sorensen
2008-05-03 18:48 ` H. Peter Anvin
2008-05-03 20:07 ` Mikael Pettersson
2008-05-03 20:03 ` H. Peter Anvin
2008-05-03 17:42 ` H. Peter Anvin
2008-05-03 17:50 ` James Courtier-Dutton
2008-05-03 17:51 ` H. Peter Anvin
2008-05-03 18:18 ` Thomas Gleixner
2008-05-03 18:58 ` Mikael Pettersson
2008-05-03 19:03 ` H. Peter Anvin
2008-05-03 19:08 ` H. Peter Anvin
2008-05-03 19:17 ` Thomas Gleixner
2008-05-03 19:24 ` H. Peter Anvin
2008-05-03 19:54 ` Ingo Molnar
2008-05-03 19:56 ` H. Peter Anvin
2008-05-03 19:49 ` Maciej W. Rozycki
2008-05-03 20:06 ` H. Peter Anvin
2008-05-03 21:17 ` Maciej W. Rozycki
2008-05-03 21:46 ` jamal
[not found] ` <Pine.LNX.4.55.0805032209480.20206@c <1209851170.6972.64.camel@localhost>
2008-05-04 13:08 ` Sebastian Herbszt
2008-05-04 15:06 ` jamal
2008-05-04 15:21 ` Sebastian Herbszt
2008-05-04 20:24 ` Arjan van de Ven
2008-05-04 21:07 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080503173402.GA5292@elte.hu \
--to=mingo@elte.hu \
--cc=arjan@linux.intel.com \
--cc=hadi@cyberus.ca \
--cc=hpa@zytor.com \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox