From: Ingo Molnar <mingo@elte.hu>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Jean Delvare <khali@linux-fr.org>
Subject: Re: [patch] video: build fix for drivers/media/video/mt9v022.c
Date: Sat, 3 May 2008 21:50:54 +0200 [thread overview]
Message-ID: <20080503195054.GD25097@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.64.0805032004130.5182@axis700.grange>
* Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
> Ok, right, sorry, the patch was indeed correct, just the reason for
> the compilation breakage was not quite what you suggested. So, I'll
> apply your putch, but please fix mt9m001.c in the same patch too - it
> also includes gpio.h conditionally. Although, it does test the correct
> macro.
>
> Actually, this CONFIG option might disappear completely in the future,
> if we decide to switch to a module parameter instead. So that one
> kernel can be used on systems with and without the GPIO.
ok - untested patch for mt9m001.c attached.
Ingo
Index: linux/drivers/media/video/mt9m001.c
===================================================================
--- linux.orig/drivers/media/video/mt9m001.c
+++ linux/drivers/media/video/mt9m001.c
@@ -12,15 +12,12 @@
#include <linux/slab.h>
#include <linux/i2c.h>
#include <linux/log2.h>
+#include <linux/gpio.h>
#include <media/v4l2-common.h>
#include <media/v4l2-chip-ident.h>
#include <media/soc_camera.h>
-#ifdef CONFIG_MT9M001_PCA9536_SWITCH
-#include <asm/gpio.h>
-#endif
-
/* mt9m001 i2c address 0x5d
* The platform has to define i2c_board_info
* and call i2c_register_board_info() */
next prev parent reply other threads:[~2008-05-03 19:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-03 16:30 [patch] video: build fix for drivers/media/video/mt9v022.c Ingo Molnar
2008-05-03 17:02 ` Guennadi Liakhovetski
2008-05-03 17:58 ` Ingo Molnar
2008-05-03 18:15 ` Guennadi Liakhovetski
2008-05-03 19:50 ` Ingo Molnar [this message]
2008-05-05 14:17 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080503195054.GD25097@elte.hu \
--to=mingo@elte.hu \
--cc=g.liakhovetski@gmx.de \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox