From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: [patch] sysfs: build fix
Date: Sun, 4 May 2008 09:29:43 +0200 [thread overview]
Message-ID: <20080504072943.GA13168@elte.hu> (raw)
In-Reply-To: <alpine.LFD.1.10.0805031205330.2971@woody.linux-foundation.org>
x86.git testing found the following build failure on v2.6.26-rc1:
In file included from include/linux/kobject.h:22,
from include/linux/module.h:17,
from include/linux/crypto.h:22,
from arch/x86/kernel/asm-offsets_32.c:8,
from arch/x86/kernel/asm-offsets.c:3:
include/linux/sysfs.h:201: error: redefinition of 'sysfs_update_group'
include/linux/sysfs.h:195: error: previous definition of 'sysfs_update_group' was here
make[1]: *** [arch/x86/kernel/asm-offsets.s] Error 1
make: *** [prepare0] Error 2
with the following config:
http://redhat.com/~mingo/misc/config-Sun_May__4_07_09_30_CEST_2008.bad
the reason for the build failure is the duplicate definition of the
sysfs_update_group() inline function in include/linux/sysfs.h.
The duplication was a merge error: it was added via -mm by commit
v2.6.25-7262-g2850699, "sysfs: sysfs_update_group stub for
CONFIG_SYSFS=n" a day before v2.6.26-rc1, but a day before that the same
commit was already merged upstream via the sysfs tree, with commit
v2.6.25-7211-g1cbfb7a.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
include/linux/sysfs.h | 6 ------
1 file changed, 6 deletions(-)
Index: linux/include/linux/sysfs.h
===================================================================
--- linux.orig/include/linux/sysfs.h
+++ linux/include/linux/sysfs.h
@@ -196,12 +196,6 @@ static inline int sysfs_update_group(str
return 0;
}
-static inline int sysfs_update_group(struct kobject *kobj,
- const struct attribute_group *grp)
-{
- return 0;
-}
-
static inline void sysfs_remove_group(struct kobject *kobj,
const struct attribute_group *grp)
{
next prev parent reply other threads:[~2008-05-04 7:30 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8287f540805041818g534c4e02qaadb0e749c5f3439@mail.gmail.com>
2008-05-03 19:38 ` Linux 2.6.26-rc1 Linus Torvalds
2008-05-03 21:47 ` Alistair John Strachan
2008-05-03 21:53 ` Alistair John Strachan
2008-05-04 12:30 ` Robin Holt
2008-05-04 13:56 ` Alistair John Strachan
2008-05-04 16:09 ` Robin Holt
2008-05-04 16:33 ` Alistair John Strachan
2008-05-05 21:04 ` Mauro Carvalho Chehab
2008-05-06 8:02 ` Alistair John Strachan
2008-05-06 10:31 ` Mauro Carvalho Chehab
2008-05-06 14:34 ` Stefan Richter
2008-05-06 14:54 ` Stefan Richter
2008-05-06 19:13 ` Mauro Carvalho Chehab
2008-05-06 19:44 ` Stefan Richter
2008-05-06 20:06 ` Mauro Carvalho Chehab
2008-05-06 20:47 ` Stefan Richter
2008-05-06 22:39 ` Mauro Carvalho Chehab
2008-05-06 23:36 ` Stefan Richter
2008-05-08 12:48 ` Mauro Carvalho Chehab
2008-05-08 14:11 ` Stefan Richter
2008-05-06 23:48 ` Stefan Richter
2008-05-04 7:29 ` Ingo Molnar [this message]
2008-05-04 18:40 ` Jan Engelhardt
2008-05-05 5:39 ` Andreas Mohr
2008-05-05 7:30 ` Ingo Molnar
2008-05-05 20:14 ` Mauro Carvalho Chehab
2008-05-06 13:07 ` Ingo Molnar
2008-05-07 8:35 ` Ingo Molnar
2008-05-05 23:51 ` Stephen Rothwell
2008-05-05 23:55 ` David Miller
2008-05-06 0:16 ` Andrew Morton
2008-05-06 5:57 ` Stephen Rothwell
2008-05-06 0:21 ` Ingo Molnar
2008-05-06 5:35 ` Stephen Rothwell
2008-05-06 6:56 ` David Miller
2008-05-06 7:26 ` Stephen Rothwell
2008-05-06 0:17 ` Ingo Molnar
2008-05-06 5:48 ` Stephen Rothwell
2008-05-06 6:07 ` Scheduling problems ? [ Was: Linux 2.6.26-rc1 ] J.A. Magallón
2008-05-06 13:11 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080504072943.GA13168@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox