* [PATCH] x86: remove spew print out about bus to node mapping
@ 2008-05-04 20:41 Yinghai Lu
2008-05-05 7:01 ` Ingo Molnar
2008-05-05 7:06 ` Thomas Gleixner
0 siblings, 2 replies; 4+ messages in thread
From: Yinghai Lu @ 2008-05-04 20:41 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner, Jeff Garzik; +Cc: linux-kernel@vger.kernel.org
Jeff Garzik pointed out that is not needed. looks like spam.
Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
diff --git a/arch/x86/pci/k8-bus_64.c b/arch/x86/pci/k8-bus_64.c
index ab6d4b1..5c2799c 100644
--- a/arch/x86/pci/k8-bus_64.c
+++ b/arch/x86/pci/k8-bus_64.c
@@ -504,14 +504,6 @@ static int __init early_fill_mp_bus_info(void)
}
}
-#ifdef CONFIG_NUMA
- for (i = 0; i < BUS_NR; i++) {
- node = mp_bus_to_node[i];
- if (node >= 0)
- printk(KERN_DEBUG "bus: %02x to node: %02x\n", i, node);
- }
-#endif
-
for (i = 0; i < pci_root_num; i++) {
int res_num;
int busnum;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: remove spew print out about bus to node mapping
2008-05-04 20:41 [PATCH] x86: remove spew print out about bus to node mapping Yinghai Lu
@ 2008-05-05 7:01 ` Ingo Molnar
2008-05-05 7:06 ` Thomas Gleixner
1 sibling, 0 replies; 4+ messages in thread
From: Ingo Molnar @ 2008-05-05 7:01 UTC (permalink / raw)
To: yhlu.kernel; +Cc: Thomas Gleixner, Jeff Garzik, linux-kernel@vger.kernel.org
* Yinghai Lu <yhlu.kernel.send@gmail.com> wrote:
> Jeff Garzik pointed out that is not needed. looks like spam.
applied, thanks.
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: remove spew print out about bus to node mapping
2008-05-04 20:41 [PATCH] x86: remove spew print out about bus to node mapping Yinghai Lu
2008-05-05 7:01 ` Ingo Molnar
@ 2008-05-05 7:06 ` Thomas Gleixner
2008-05-05 17:39 ` Yinghai Lu
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Gleixner @ 2008-05-05 7:06 UTC (permalink / raw)
To: yhlu.kernel; +Cc: Ingo Molnar, Jeff Garzik, linux-kernel@vger.kernel.org
On Sun, 4 May 2008, Yinghai Lu wrote:
> Jeff Garzik pointed out that is not needed. looks like spam.
>
> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
>
> diff --git a/arch/x86/pci/k8-bus_64.c b/arch/x86/pci/k8-bus_64.c
> index ab6d4b1..5c2799c 100644
> --- a/arch/x86/pci/k8-bus_64.c
> +++ b/arch/x86/pci/k8-bus_64.c
> @@ -504,14 +504,6 @@ static int __init early_fill_mp_bus_info(void)
> }
> }
>
> -#ifdef CONFIG_NUMA
> - for (i = 0; i < BUS_NR; i++) {
> - node = mp_bus_to_node[i];
> - if (node >= 0)
> - printk(KERN_DEBUG "bus: %02x to node: %02x\n", i, node);
> - }
> -#endif
> -
> for (i = 0; i < pci_root_num; i++) {
> int res_num;
> int busnum;
>
What about this loop, looks noisy as well ?
Thanks,
tglx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86: remove spew print out about bus to node mapping
2008-05-05 7:06 ` Thomas Gleixner
@ 2008-05-05 17:39 ` Yinghai Lu
0 siblings, 0 replies; 4+ messages in thread
From: Yinghai Lu @ 2008-05-05 17:39 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: Ingo Molnar, Jeff Garzik, linux-kernel@vger.kernel.org
On Mon, May 5, 2008 at 12:06 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Sun, 4 May 2008, Yinghai Lu wrote:
> > Jeff Garzik pointed out that is not needed. looks like spam.
> >
> > Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
> >
> > diff --git a/arch/x86/pci/k8-bus_64.c b/arch/x86/pci/k8-bus_64.c
> > index ab6d4b1..5c2799c 100644
> > --- a/arch/x86/pci/k8-bus_64.c
> > +++ b/arch/x86/pci/k8-bus_64.c
> > @@ -504,14 +504,6 @@ static int __init early_fill_mp_bus_info(void)
> > }
> > }
> >
> > -#ifdef CONFIG_NUMA
> > - for (i = 0; i < BUS_NR; i++) {
> > - node = mp_bus_to_node[i];
> > - if (node >= 0)
> > - printk(KERN_DEBUG "bus: %02x to node: %02x\n", i, node);
> > - }
> > -#endif
> > -
> > for (i = 0; i < pci_root_num; i++) {
> > int res_num;
> > int busnum;
> >
>
> What about this loop, looks noisy as well ?
>
for (i = 0; i < pci_root_num; i++) { ?
it is informative, about node/link to bus range...
YH
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-05-05 17:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-04 20:41 [PATCH] x86: remove spew print out about bus to node mapping Yinghai Lu
2008-05-05 7:01 ` Ingo Molnar
2008-05-05 7:06 ` Thomas Gleixner
2008-05-05 17:39 ` Yinghai Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox