From: Pradeep Singh Rautela <rautelap@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: rautelap@gmail.com, akpm@linux-foundation.org,
linux-netdev@vger.kernel.org
Subject: [PATCH] fc: Fix fc.c to adhere to kernel Coding style
Date: Mon, 5 May 2008 00:29:13 +0530 [thread overview]
Message-ID: <20080504185913.GA13605@kernelpanic> (raw)
net: fc.c does not strictly adheres to kernel coding style.
Fix it by changing some occurences of
if
{
...;
}
else
{
...;
}
to
if {
...;
} else {
...;
}
Signed-off-by: Pradeep Singh <rautelap@gmail.com>
---
net/802/fc.c | 10 +++-------
1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/net/802/fc.c b/net/802/fc.c
index cb3475e..7062605 100644
--- a/net/802/fc.c
+++ b/net/802/fc.c
@@ -44,8 +44,7 @@ static int fc_header(struct sk_buff *skb, struct net_device *dev,
* Add the 802.2 SNAP header if IP as the IPv4 code calls
* dev->hard_header directly.
*/
- if (type == ETH_P_IP || type == ETH_P_ARP)
- {
+ if (type == ETH_P_IP || type == ETH_P_ARP) {
struct fcllc *fcllc;
hdr_len = sizeof(struct fch_hdr) + sizeof(struct fcllc);
@@ -55,9 +54,7 @@ static int fc_header(struct sk_buff *skb, struct net_device *dev,
fcllc->llc = UI_CMD;
fcllc->protid[0] = fcllc->protid[1] = fcllc->protid[2] = 0x00;
fcllc->ethertype = htons(type);
- }
- else
- {
+ } else {
hdr_len = sizeof(struct fch_hdr);
fch = (struct fch_hdr *)skb_push(skb, hdr_len);
}
@@ -67,8 +64,7 @@ static int fc_header(struct sk_buff *skb, struct net_device *dev,
else
memcpy(fch->saddr,dev->dev_addr,dev->addr_len);
- if(daddr)
- {
+ if (daddr) {
memcpy(fch->daddr,daddr,dev->addr_len);
return(hdr_len);
}
--
1.5.5.1
reply other threads:[~2008-05-04 18:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080504185913.GA13605@kernelpanic \
--to=rautelap@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox