Re: [PATCH 01 of 11] mmu-notifier-core

Linus Torvalds
2008-05-07T20:32:01Z

On Wed, 7 May 2008, Andrew Morton wrote:
>
> The patch looks OK to me.

As far as I can tell, authorship has been destroyed by at least two of the
patches (ie Christoph seems to be the author, but Andrea seems to have
dropped that fact).

> The proposal is that we sneak this into 2.6.26. Are there any
> sufficiently-serious objections to this?

Yeah, too late and no upside.

That "locking" code is also too ugly to live, at least without some
serious arguments for why it has to be done that way. Sorting the locks?
In a vmalloc'ed area? And calling this something innocuous like
"mm_lock()"? Hell no.

That code needs some serious re-thinking.

Linus