Re: [PATCH 01 of 11] mmu-notifier-core

Linus Torvalds
2008-05-07T22:18:25Z

On Wed, 7 May 2008, Andrea Arcangeli wrote:

> > As far as I can tell, authorship has been destroyed by at least two of the
> > patches (ie Christoph seems to be the author, but Andrea seems to have
> > dropped that fact).
>
> I can't follow this, please be more specific.

The patches were sent to lkml without *any* indication that you weren't
actually the author.

So if Andrew had merged them, they would have been merged as yours.

> > That "locking" code is also too ugly to live, at least without some
> > serious arguments for why it has to be done that way. Sorting the locks?
> > In a vmalloc'ed area? And calling this something innocuous like
> > "mm_lock()"? Hell no.
>
> That's only invoked in mmu_notifier_register, mm_lock is explicitly
> documented as heavyweight function.

Is that an excuse for UTTER AND TOTAL CRAP?

Linus