Re: [lm-sensors] [PATCH] i5k_amb: Support Intel 5400 chipset

[Andrew Morton <akpm@linux-foundation.org>]

On Mon, 5 May 2008 23:22:45 +0200
Jean Delvare <khali@linux-fr.org> wrote:

> Hi Andrew,
> 
> On Mon, 5 May 2008 13:56:21 -0700, Andrew Morton wrote:
> > On Fri, 2 May 2008 21:55:59 -0700
> > "Darrick J. Wong" <djwong@us.ibm.com> wrote:
> > 
> > > Minor rework to support the Intel 5400 chipset.
> > 
> > Thanks, I added this to the for-git-hwmon part of the -mm queue.
> > 
> > I haven't heard from Mark for quite some time so soon I might declare him
> > absent and I'll go through my hwmon patches with a view to merging them into
> > 2.6.26 directly.
> 
> For Mark's status see:
> http://lists.lm-sensors.org/pipermail/lm-sensors/2008-May/023006.html
> 
> I guess he'll be happy if you merge a couple patches for him.

hm, OK.

> > 
> > That queue currently consists of:
> > 
> > hdaps-invert-the-axes-for-hdaps-on-lenovo-r61i-thinkpads.patch
> > adt746x-logical-bitwise-confusion-in-set_max_duty_at_crit.patch
> 
> The adt7473:set_max_duty_at_crit() code was originally confusing but
> correct. After this patch the code is clear but broken. Is it
> considered an improvement?

I'll drop it.

> (I would have told you before if that patch had been submitted to the
> lm-sensors list as it should have, given that it modifies a hardware
> monitoring driver... Not to mention that the patch file name doesn't
> match the driver file name, just to add to the confusion.)

Well, y'know, stuff happens.  Stuff like you forgetting to cc that
patch's author on this email.

> > adt7473-minor-documentation-update.patch
> 
> I reviewed and acked that one, it's ready to go.

OK, thanks.

> > i5k_amb-support-intel-5400-chipset.patch