From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756595AbYEEEzY (ORCPT ); Mon, 5 May 2008 00:55:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752205AbYEEEzK (ORCPT ); Mon, 5 May 2008 00:55:10 -0400 Received: from ozlabs.org ([203.10.76.45]:32975 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752057AbYEEEzJ (ORCPT ); Mon, 5 May 2008 00:55:09 -0400 From: Rusty Russell To: Linus Torvalds Subject: Re: changeset: Make forced module loading optional Date: Mon, 5 May 2008 14:55:02 +1000 User-Agent: KMail/1.9.9 Cc: linux-kernel@vger.kernel.org, Jon Masters , Sam Ravnborg MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200805051455.02723.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus's recent commit said: > The kernel module loader used to be much too happy to allow loading of > modules for the wrong kernel version by default. For example, if you > had MODVERSIONS enabled, but tried to load a module with no version > info, it would happily load it and taint the kernel - whether it was > likely to actually work or not! ... > Especially as it happened to me by mistake (ie regular unversioned Fedora > modules getting loaded) causing lots of strange behavior. Hi Linus, I'm trying to figure out how you did this. So fedora builds unversioned modules, and version (and vermagic) matched your kernel? And you somehow mixed them up? I don't think relying on modversions is the complete answer here. Perhaps we should make modules_install blow away old modules? Cheers, Rusty.