From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: w@1wt.eu, linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: Fix VT canonical input in UTF-8 mode [Was: UTF-8 fixes in comments]
Date: Tue, 6 May 2008 00:54:34 +0100 [thread overview]
Message-ID: <20080505235434.GE4790@implementation> (raw)
In-Reply-To: <20080505160044.dcc36a51.akpm@linux-foundation.org>
Andrew Morton, le Mon 05 May 2008 16:00:44 -0700, a écrit :
> > Set IUTF8 as appropriate on VT tty open.
> >
> > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> That changelog is pretty darn terse :(
Erf, sorry.
> I'll often go through
> the email ladder and try to extract the missing information
> but this time I don't really see it there.
>
> Things like: what is the kernel's current behaviour, why does
> it behave that way, how does the patch fix it?
Well, it's more an implementation than a fix. Let's try again:
For e.g. proper TTY canonical support, IUTF8 termios flag has to be set
as appropriate. Linux used to not care about setting that flag for VT
TTYs.
This patch fixes that by activating it according to the current mode
of the VT, and sets the default value according to the vt.default_utf8
parameter.
Samuel
prev parent reply other threads:[~2008-05-05 23:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 0:08 [2.6 patch] UTF-8 fixes in comments Samuel Thibault
2008-04-30 3:38 ` Chris Adams
2008-04-30 9:38 ` Samuel Thibault
2008-04-30 19:45 ` Willy Tarreau
2008-04-30 19:49 ` Willy Tarreau
2008-05-03 23:50 ` Samuel Thibault
2008-05-04 8:55 ` Willy Tarreau
2008-05-04 10:25 ` Fix VT canonical input in UTF-8 mode [Was: UTF-8 fixes in comments] Samuel Thibault
2008-05-04 11:03 ` Willy Tarreau
2008-05-05 23:00 ` Andrew Morton
2008-05-05 23:54 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080505235434.GE4790@implementation \
--to=samuel.thibault@ens-lyon.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox