Re: [PATCH] default to n for GROUP_SCHED and FAIR_GROUP_SCHED

Sam Ravnborg
2008-05-05T19:01:29Z

On Mon, May 05, 2008 at 08:42:35PM +0200, Ingo Molnar wrote:
>
> * Sam Ravnborg <sam@ravnborg.org> wrote:
>
> > > This is a many years old kconfig bug that is frequently hacked
> > > around in distro kernel packages but which has been ignored upstream
> > > - i've attached Fedora's nonint_oldconfig patch from Dave Jones
> > > below. (maybe Arjan wrote it originally?)
> >
> > In latest kbuild.git I've added a new feature.
> >
> > make K=.config alldefconfig
> >
> > would give you eaxtly what you request here. K= is used to say where
> > to locate the base-configuration.
>
> great, thanks Sam!
>
> ( how hard would it be to fix the "make oldconfig < /dev/null" infinit
> loop bug btw? I've got this method in a number of scripts of mine and
> it's an intuitive thing to type anyway, i think users would like it if
> it Just Worked. )

Let me try (on my i386 box so I use x86_&4 so I know oldconfig will ask):
$ make defconfig ARCH=x86_64
#
# configuration is based on '/home/sam/kernel/kbuild.git/arch/x86/configs/x86_64_defconfig'
#
# configuration written to .config
#
$ make oldconfig > /dev/null
aborted!

Console input/output is redirected. Run 'make oldconfig' to update configuration.

make[1]: *** [oldconfig] Error 1
make: *** [oldconfig] Error 2

And then with a config that does not need an update:
$ make defconfig
#
# configuration is based on '/home/sam/kernel/kbuild.git/arch/x86/configs/i386_defconfig'
#
# configuration written to .config
#
$ make oldconfig > /dev/null
$

Seems like I already fixed it :-)
That was a side-effect of touching some code in conf.c

Note by the way the output of 'make oldconfig' - nada.
I simply dropped the chatty mode as noone used it
for anything sensible anymore.

Sam