Re: [PATCH] default to n for GROUP_SCHED and FAIR_GROUP_SCHED

Ingo Molnar
2008-05-05T17:15:40Z

* Parag Warudkar <parag.warudkar@gmail.com> wrote:

> sched-devel does not boot on my machine - stops right after PCI: Not
> using mmconfig.
>
> Here is my config for sched-devel - I did a echo "n" | make oldconfig
> after copying over the previous config file BTW. Should I try
> disabling things in config? What's most likely to break boot? (Seems
> likes there are a lot of significant changes in there.)

every config is supposed to work, but in general you should pick the
defaults instead of saying 'n' to all questions. As long as every
question can be answered with an 'enter', this should work:

make oldconfig < /dev/null

this non-interactive 'make oldconfig' will hang with the kconfig tool
looping infinitely if there's any numeric question that cannot be
answered via 'enter'.

This is a many years old kconfig bug that is frequently hacked around in
distro kernel packages but which has been ignored upstream - i've
attached Fedora's nonint_oldconfig patch from Dave Jones below. (maybe
Arjan wrote it originally?)

Ingo

---
scripts/kconfig/Makefile | 3 +++
scripts/kconfig/conf.c | 28 ++++++++++++++++++++++++----
2 files changed, 27 insertions(+), 4 deletions(-)

Index: linux/scripts/kconfig/Makefile
===================================================================
--- linux.orig/scripts/kconfig/Makefile
+++ linux/scripts/kconfig/Makefile
@@ -24,6 +24,9 @@ oldconfig: $(obj)/conf
silentoldconfig: $(obj)/conf
$< -s $(Kconfig)

+nonint_oldconfig: scripts/kconfig/conf
+ ./scripts/kconfig/conf -b arch/x86/Kconfig
+
# Create new linux.pot file
# Adjust charset to UTF-8 in .po file to accept UTF-8 in Kconfig files
# The symlink is used to repair a deficiency in arch/um
Index: linux/scripts/kconfig/conf.c
===================================================================
--- linux.orig/scripts/kconfig/conf.c
+++ linux/scripts/kconfig/conf.c
@@ -22,6 +22,7 @@ enum {
ask_all,
ask_new,
ask_silent,
+ dont_ask,
set_default,
set_yes,
set_mod,
@@ -46,6 +47,8 @@ static const char *get_help(struct menu
return nohelp_text;
}

+static int return_value = 0;
+
static void strip(char *str)
{
char *p = str;
@@ -112,6 +115,12 @@ static int conf_askvalue(struct symbol *
fflush(stdout);
fgets(line, 128, stdin);
return 1;
+ case dont_ask:
+ if (!sym_has_value(sym)) {
+ fprintf(stderr,"CONFIG_%s\n",sym->name);
+ return_value++;
+ }
+ return;
case set_default:
printf("%s\n", def);
return 1;
@@ -351,6 +360,10 @@ static int conf_choice(struct menu *menu
printf("?");
printf("]: ");
switch (input_mode) {
+ case dont_ask:
+ cnt = def;
+ printf("%d\n", cnt);
+ break;
case ask_new:
case ask_silent:
if (!is_new) {
@@ -486,7 +499,10 @@ static void check_conf(struct menu *menu
if (!conf_cnt++)
printf(_("*\n* Restart config...\n*\n"));
rootEntry = menu_get_parent_menu(menu);
- conf(rootEntry);
+ if (input_mode == dont_ask)
+ fprintf(stderr,"CONFIG_%s\n",sym->name);
+ else
+ conf(rootEntry);
}
}

@@ -504,11 +520,14 @@ int main(int ac, char **av)
bindtextdomain(PACKAGE, LOCALEDIR);
textdomain(PACKAGE);

- while ((opt = getopt(ac, av, "osdD:nmyrh")) != -1) {
+ while ((opt = getopt(ac, av, "obsdD:nmyrh")) != -1) {
switch (opt) {
case 'o':
input_mode = ask_new;
break;
+ case 'b':
+ input_mode = dont_ask;
+ break;
case 's':
input_mode = ask_silent;
valid_stdin = isatty(0) && isatty(1) && isatty(2);
@@ -573,6 +592,7 @@ int main(int ac, char **av)
}
case ask_all:
case ask_new:
+ case dont_ask:
conf_read(NULL);
break;
case set_no:
@@ -619,7 +639,7 @@ int main(int ac, char **av)
do {
conf_cnt = 0;
check_conf(&rootmenu);
- } while (conf_cnt);
+ } while ((conf_cnt) && (input_mode != dont_ask));
if (conf_write(NULL)) {
fprintf(stderr, _("\n*** Error during writing of the kernel configuration.\n\n"));
return 1;
@@ -630,5 +650,5 @@ skip_check:
return 1;
}

- return 0;
+ return return_value;
}